1130059 - Enable Shumway whitelisted for some Flash video content: Nightly channel only; Windows Vista+ and OS X only.

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Chris Peterson [:cpeterson]]

We can't enable on Linux yet because we need H.264 platform decoders for the Flash content we have whitelisted (Amazon video).

Comment 1

[Chris Peterson [:cpeterson]]

We will probably need to disable Shumway on Windows XP, too, because we don't have an H.264 platform decoder.

Comment 2

[Till Schneidereit [:till]]

Attachment: Enable Shumway by default in Nightly on OS X and Windows Vista+ for whitelisted SWFs

This patch enables Shumway for the Amazon video player on systems that're known to have suitable h.264 decoders. (The detection of Vista+ is done in browser/extensions/shumway/content/ShumwayBootstrapUtils.jsm at runtime.)

We want to get this in as a first, conservative step towards having Shumway take over for high-value content that we know to work. The Amazon video player has undergone extensive testing and it works very well in Shumway.

Our startup time is currently worse than the Flash plugin's, but for the Amazon video player it's still fast enough to feel almost immediate. We're working on improving startup time and will get it to be competitive with Flash before Shumway rides the trains.

There's potential for a startup time regression, but a Talos run of a functionally identical patch didn't show any major changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0162b2eb78ef

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8561455 [details] [diff] [review]
Enable Shumway by default in Nightly on OS X and Windows Vista+ for whitelisted SWFs

Please invert the conditional to use "ifdef UNIX_BUT_NOT_MAC" instead of ifndef.

Comment 4

[Till Schneidereit [:till]]

Thanks for the review!
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a793dd926e90

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a793dd926e90