Closed
Bug 1130132
Opened 10 years ago
Closed 10 years ago
add telemetry comparing system and geoIP based location for Windows
Categories
(Firefox :: Search, defect)
Tracking
()
People
(Reporter: Gavin, Assigned: markh)
References
Details
Attachments
(1 file, 1 obsolete file)
8.00 KB,
patch
|
Gavin
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The Windows version of bug 1121340.
Reporter | ||
Updated•10 years ago
|
status-firefox37:
--- → affected
status-firefox38:
--- → affected
tracking-firefox37:
--- → +
tracking-firefox38:
--- → +
Reporter | ||
Comment 1•10 years ago
|
||
We should get this in 37 to get an earlier decision on whether to pursue bug 1115106.
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(mhammond)
Reporter | ||
Comment 2•10 years ago
|
||
Mark can you take this?
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Assignee | ||
Comment 3•10 years ago
|
||
A fairly simple patch given the foundation was already set by the OSX patch.
Note however that as Windows also uses nsIGfxInfo2, Windows builds are going to start reporting the _OSX probes as there was no specific check for OSX in nsSearchService (sadly, I expected the use of nsIGfxInfo2 was a hack for Mac only and Windows would do something different - but I was wrong!) Thus we should get this landed and uplifted ASAP.
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Flags: needinfo?(mhammond)
Attachment #8563146 -
Flags: review?(gavin.sharp)
Updated•10 years ago
|
Iteration: --- → 38.3 - 23 Feb
Assignee | ||
Comment 4•10 years ago
|
||
ack - I neglected to change some comments in the test which are fixed here.
Attachment #8563146 -
Attachment is obsolete: true
Attachment #8563146 -
Flags: review?(gavin.sharp)
Attachment #8563149 -
Flags: review?(gavin.sharp)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8563149 [details] [diff] [review]
0001-Bug-1130132-add-telemetry-to-determine-how-consisten.patch
Oops, yes.
Attachment #8563149 -
Flags: review?(gavin.sharp) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8563149 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Note to sheriffs - to avoid Aurora recording bad telemetry data, please uplift this patch at the same time as bug 1121340 (but note that this bug depends on that)
Whiteboard: [sheriff note in comment 7]
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•