Closed Bug 1130132 Opened 8 years ago Closed 8 years ago
add telemetry comparing system and geo
IP based location for Windows
The Windows version of bug 1121340.
We should get this in 37 to get an earlier decision on whether to pursue bug 1115106.
Mark can you take this?
Points: --- → 1
A fairly simple patch given the foundation was already set by the OSX patch. Note however that as Windows also uses nsIGfxInfo2, Windows builds are going to start reporting the _OSX probes as there was no specific check for OSX in nsSearchService (sadly, I expected the use of nsIGfxInfo2 was a hack for Mac only and Windows would do something different - but I was wrong!) Thus we should get this landed and uplifted ASAP.
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #8563146 - Flags: review?(gavin.sharp)
ack - I neglected to change some comments in the test which are fixed here.
Comment on attachment 8563149 [details] [diff] [review] 0001-Bug-1130132-add-telemetry-to-determine-how-consisten.patch Oops, yes.
Attachment #8563149 - Flags: review?(gavin.sharp) → review+
Attachment #8563149 - Flags: approval-mozilla-aurora+
Note to sheriffs - to avoid Aurora recording bad telemetry data, please uplift this patch at the same time as bug 1121340 (but note that this bug depends on that)
Whiteboard: [sheriff note in comment 7]
You need to log in before you can comment on or make changes to this bug.