1130202 - Performance++ should work with Fx2.2

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Gecko 37 (Fx2.2)
Mocks: No mocks
Features: should have all the same features as desktop

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

FxOS 2.2 (Gecko 37) Error:

Handler function DebuggerTransport instance's this.hooks.onPacket threw an exception: TypeError: v.split is not a function
Stack: .read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/timeline.js:47:16
Arg<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:455:27
Request<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:643:1
Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1177:16
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:906:7
DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:461:9
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
Line: 47, column: 15
console.error: 
  Error reading event: ticks
console.error: 
  Message: TypeError: v.split is not a function
  Stack:
    .read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/timeline.js:47:16
Arg<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:455:27
Request<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:643:1
Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1177:16
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:906:7
DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:461:9
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

We'll also need to support multi threads on the front end as gaia is multi-threaded (??)

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

The tab target methods (actorHasMethod) is returning that there is no definition for memoryActor even though it exists on the device. I'm guessing by the time `getActorDescription` is called, the actor has not yet registered itself on the device. We'll need to add polling to the TabTarget methods if the actor is found on the root (which is synchronous), so we can continue polling until the description is fetched, to determine what methods are registered on the actor.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Created bug 1132474 for the tab target fix

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1130202-fx22.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7b983909621

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Supports everything but the memory calltree/flame graph.

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 8563602 [details] [diff] [review]
1130202-fx22.patch

Review of attachment 8563602 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/timeline.js
@@ +44,5 @@
>   */
>  protocol.types.addType("array-of-numbers-as-strings", {
>    write: (v) => v.join(","),
> +  // In Gecko <= 37, `v` is an array; do not transform in this case.
> +  read: (v) => typeof v === "string" ? v.split(",") : v

I think you want : JSON.parse(v), right? Both cases are a string, just one looks like "[1, 2, 3]", and the other one looks like "1,2,3".

But I have no idea.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

In Fx37, it is indeed an array

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/8e757a59c0f5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e757a59c0f5