Closed Bug 1130202 Opened 5 years ago Closed 5 years ago

Performance++ should work with Fx2.2

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

37 Branch
x86
macOS
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

Gecko 37 (Fx2.2)
Mocks: No mocks
Features: should have all the same features as desktop
Depends on: 1130204
FxOS 2.2 (Gecko 37) Error:

Handler function DebuggerTransport instance's this.hooks.onPacket threw an exception: TypeError: v.split is not a function
Stack: .read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/timeline.js:47:16
Arg<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:455:27
Request<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:643:1
Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1177:16
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:906:7
DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:461:9
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
Line: 47, column: 15
console.error: 
  Error reading event: ticks
console.error: 
  Message: TypeError: v.split is not a function
  Stack:
    .read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/timeline.js:47:16
Arg<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:455:27
Request<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:643:1
Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1177:16
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:906:7
DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:461:9
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
No longer depends on: 1130204
We'll also need to support multi threads on the front end as gaia is multi-threaded (??)
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
The tab target methods (actorHasMethod) is returning that there is no definition for memoryActor even though it exists on the device. I'm guessing by the time `getActorDescription` is called, the actor has not yet registered itself on the device. We'll need to add polling to the TabTarget methods if the actor is found on the root (which is synchronous), so we can continue polling until the description is fetched, to determine what methods are registered on the actor.
Created bug 1132474 for the tab target fix
Depends on: 1132474
Supports everything but the memory calltree/flame graph.
Comment on attachment 8563602 [details] [diff] [review]
1130202-fx22.patch

Review of attachment 8563602 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/timeline.js
@@ +44,5 @@
>   */
>  protocol.types.addType("array-of-numbers-as-strings", {
>    write: (v) => v.join(","),
> +  // In Gecko <= 37, `v` is an array; do not transform in this case.
> +  read: (v) => typeof v === "string" ? v.split(",") : v

I think you want : JSON.parse(v), right? Both cases are a string, just one looks like "[1, 2, 3]", and the other one looks like "1,2,3".

But I have no idea.
Attachment #8563602 - Flags: review?(vporof) → review+
In Fx37, it is indeed an array
No longer depends on: 1132474
https://hg.mozilla.org/mozilla-central/rev/8e757a59c0f5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.