1130220 - Marionette automation doesn't clean up its socket after getting killed with SIGINT

Status: RESOLVED DUPLICATE of bug 1081970

(Remote Protocol :: Marionette, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

A few people have called this out as a pain when debugging tests. The situation is: Run marionette tests. Realize something's wrong and kill with ctrl-C. Shortly thereafter run them again and get "MarionetteException: MarionetteException: localhost:2828 is unavailable.". 

A SIGINT handler in the runner might be able to ensure the appropriate cleanup happens in these cases.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1130220/chmanchester

/r/3423 - Bug 1130220 - Close marionette's socket in a signal handler when test execution is interuppted.

Pull down this commit:

hg pull review -r 7593f25bf13d2ff18437be9b0ee47f7577e94f2b

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment 1 is what I mean, and seems like an improvement trying it out locally.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Even with this patch I'm still experiencing this with the gaia-ui-tests.  The bug can be reliably reproduced running gaiatest and interrupting.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can perfectly replicate that now with latest Marionette on mozilla-central when running tests which internally restart the application. Once I run such a test, the port is still in use and Marionette cannot be run until it has been freed by the OS.

This is blocking our tests on CI given that followup jobs would fail when triggered immediately after the former finishes.

The only thing I have to do now in a tests is `self.marionette.restart(in_app=True)`. So it looks like with the landing of bug 1137388 this is a permanent failure now.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> I can perfectly replicate that now with latest Marionette on mozilla-central
> when running tests which internally restart the application. Once I run such
> a test, the port is still in use and Marionette cannot be run until it has
> been freed by the OS.
> 
> This is blocking our tests on CI given that followup jobs would fail when
> triggered immediately after the former finishes.
> 
> The only thing I have to do now in a tests is
> `self.marionette.restart(in_app=True)`. So it looks like with the landing of
> bug 1137388 this is a permanent failure now.

This has a different cause and different fix, it needs a different bug.

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1130220 - Close marionette's socket in a signal handler when test execution is interuppted.