quit() and restart() have to shutdown the application sanely by default and not by specifying `in_app=True`
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(firefox107 fixed)
Tracking | Status | |
---|---|---|
firefox107 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 5•7 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•2 years ago
|
||
This safe shutdown logic would actually apply to both the quit()
and restart()
commands. As such lets extend this bug to cover both at the same time.
Also given that we are pretty stable with in-application quits and restarts over the last months and more tests outside of our unit tests are getting added, I would propose to finally make this switch and flip the default from False
to True
.
Here a try build to see if that actually works fine:
https://treeherder.mozilla.org/jobs?repo=try&revision=c5392f953c490488412d37812bfdda28798de10c
Assignee | ||
Comment 8•2 years ago
|
||
Hereby the "in_app" argument is required to be specified in case some
other argument eg. "clean" requires a termination of the application.
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Backed out for causing failures at awsy/test_memory_usage.py.
Backout link: https://hg.mozilla.org/integration/autoland/rev/2339498ee23029401e4e0fe6d36cbb2b23684c28
Failure log: https://treeherder.mozilla.org/logviewer?job_id=391826853&repo=autoland&lineNumber=1640
Assignee | ||
Comment 11•2 years ago
|
||
The awsy harness calls self.marionette.restart(clean=False)
which formerly used in_app=False
to restart Firefox. To stay in sync I explicitly added the argument now and pushed to try:
https://treeherder.mozilla.org/jobs?repo=try&revision=f5e4da1daf8b3e42f06722b809b77449fc154d11
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•