1130250 - [Demo][Stingray] The bottom app that you selected should be a complete circle

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: screenshot

### ENV
Device: Flatfish (tv)
Gaia: alc3317848623e53115c4f39013e1bc90c3935c2

### STR
1. Enter Apps Deck by highlight and press “OK”
2. Press "Down" key repeatedly until the highlight is focused on the bottom app

### Actual Result
1. The bottom app that you selected is not a complete circle

### Expected Result
1. The bottom app that you selected should be a complete circle.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] sean2449:Bug_1130250 to mozilla-b2g:master

Comment 2

[Sung Chiu[:sungchiu]]

Attachment: Pull Request

1. Add a 'after' element in the grid view with height 4rem

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8561295 [details] [review]
Pull Request

Change reviewer to Tzu-lin.

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8561295 [details] [review]
Pull Request

Looks good to me, thanks

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8561295 [details] [review]
Pull Request

Although 4rem looks so strange, it fixes the issue. We should file a bug to track the text and button shaking while focus moves without this patch.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/462a2ef9e98134255c144e373c7392440e3ee03b

gaia try is all green
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=add6031ddd82