Closed Bug 1130274 Opened 7 years ago Closed 7 years ago

JS and Memory flame graphs get rerendered but don't actually change when prefs are modified

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

This is because we cache rendering data sources, and even though everything *is* rerendered, it's the same.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8560280 - Flags: review?(jsantell)
Comment on attachment 8560280 [details] [diff] [review]
v1

Review of attachment 8560280 [details] [diff] [review]:
-----------------------------------------------------------------

good spotting this one
Attachment #8560280 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/e4ed2f7b72c5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.