1130362 - [e10s] focus rectangles briefly render as black rects when switching tabs

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Jim Mathies [:jimm]]

STR:

1) open up a bugzilla list of bugs (tab #1)
2) ctrl-click a bug link

result: in e10s mode, the bug should open in a background tab (tab #2), and the link should get a focus rect.

3) tab switch using the mouse from tab #1 to tab #2

result: a black rect will display briefly where the focus rect of the previous tab is located.

Comment 1

[Benoit Girard (:BenWa)]

This could be related to bug 1067470 and/or bug 1129194.

How often can you reproduce and if so what is your about:support?

Comment 2

[Jim Mathies [:jimm]]

(In reply to Benoit Girard (:BenWa) from comment #1)
> This could be related to bug 1067470 and/or bug 1129194.
> 
> How often can you reproduce and if so what is your about:support?

When flipping back and forth between two tabs, maybe 1 out five tab switches. I see this in other random cases as well.

Comment 3

[Jim Mathies [:jimm]]

Attachment: support.txt

Comment 4

[Benoit Girard (:BenWa)]

D3D11 + D2D 1.1 (not sure if WARP or not)

Comment 5

[Benoit Girard (:BenWa)]

Attachment: disable compositor invalidation

I can't reproduce given the same gfx backend. Can you try to reproduce using:
1) Does it reproduce with gfx.direct2d.disabled?
2) Does it reproduce with the following patch?

Comment 6

[Benoit Girard (:BenWa)]

Please ni? me or bas with the results.

Comment 7

[Jim Mathies [:jimm]]

> 1) Does it reproduce with gfx.direct2d.disabled?

yes.

> 2) Does it reproduce with the following patch?

no, but what I see instead is a black flash for the entire tab when I switch tabs. Much much worse than the original bug reported.

Also, I noticed that the black rect shows up just before I switch away from the tab with the focus rect, which is odd.

Comment 8

[Bas Schouten (:bas.schouten)]

I've tried to reproduce this on two different machines using the same rendering backends as Jim has, I can't reproduce it. Perhaps a screencast of what you're seeing could help trying to look for it, but I really think it's just not happening. That increasing the invalid rect makes things worse is interesting, it sounds like we're just doing a composite when the content isn't ready yet. It doesn't sound related to partial invalidation in that case.

Comment 9

[Jim Mathies [:jimm]]

video of the issue:

https://onedrive.live.com/?cid=04dff3f04a5ab6d0&id=4DFF3F04A5AB6D0%216627&ithint=video,mp4&authkey=!AAfjszLIJzdNK4s

sorry, my phone was upside down when I took this. Normally I'd redo but this has three good reproductions in under 8 seconds.

Comment 10

[Jim Mathies [:jimm]]

Note you don't need a focus rectangle visible to reproduce, it'll reproduce on a link that has focus and should display the focus rect even if it isn't. (This is a common theme problem on windows.)

Comment 11

[Bas Schouten (:bas.schouten)]

(In reply to Jim Mathies [:jimm] from comment #9)
> video of the issue:
> 
> https://onedrive.live.com/
> ?cid=04dff3f04a5ab6d0&id=4DFF3F04A5AB6D0%216627&ithint=video,mp4&authkey=!
> AAfjszLIJzdNK4s
> 
> sorry, my phone was upside down when I took this. Normally I'd redo but this
> has three good reproductions in under 8 seconds.

This is very mysterious, I wonder why I cannot reproduce this issue. Can you reproduce the issue when you're running inside a debug build?

Comment 12

[Bas Schouten (:bas.schouten)]

An interesting observation here is that when switching away from the tab with the focus rect, just before we switch away on my machine we redraw without the focus rect for just one frame. This seems pretty wasteful and possibly even undesirable. It's this paint that presumably is yielding black for Jim in the frame that's drawn, presumably the layers in this frame end up somehow being drawn without any content, as otherwise doing a full redraw would not show a black flash.

Comment 13

[Jim Mathies [:jimm]]

A focus rect triggers an extra paint on every tab switch?

Comment 14

[Jim Mathies [:jimm]]

Bas, do you know if this is specific to e10s?