1130452 - remove Service Worker Cache "prefixMatch" option

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

See:

  https://github.com/slightlyoff/ServiceWorker/issues/617

Implementing prefixMatch is hard to do efficiently without indexing a potentially large TEXT column in the sqlite database.  Its even harder when you throw in ignoreSearch.

The blink team agrees (and they haven't implemented it yet), so everyone seems in favor of simplifying and removing prefixMatch.

Comment 1

[(no longer active)]

Attachment: Remove support for the prefixMatch option in the service worker cache code

Requesting review from baku on the WebIDL change.

Comment 2

[(no longer active)]

(Note that I didn't change the schema to avoid stepping on Ben's toes.)

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8573537 [details] [diff] [review]
Remove support for the prefixMatch option in the service worker cache code

Review of attachment 8573537 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, I could have sworn I had a test that used prefixMatch.  But I guess I don't. :-\

> (Note that I didn't change the schema to avoid stepping on Ben's toes.)

Yea, before we remove the URL indices I need to write code to hash the URL for exact matching.  That's going to be a ton easier with prefix matching removed.

Thanks for doing this.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8573537 [details] [diff] [review]
Remove support for the prefixMatch option in the service worker cache code

Review of attachment 8573537 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/cache/DBSchema.cpp
@@ +676,5 @@
>      urlToMatch = aRequest.url();
>      query.AppendLiteral("request_url");
>    }
>  
> +  query.AppendLiteral(" =?2 GROUP BY entries.id ORDER BY entries.id;");

extra space before '='

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43d4db7da2d6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43d4db7da2d6