Closed Bug 1110144 (serviceworker-cache) Opened 6 years ago Closed 5 years ago

ship Service Worker Cache in release builds

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed
relnote-firefox --- 41+

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

This is a meta bug for all SW Cache work that must be done before the feature can be pref'd on.
I guess its more typical to just make a "pref it on" bug instead of a meta bug here.  Lets do that.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Depends on: 940273
Summary: [meta] Service Worker Cache bugs required to enable pref → enable Service Worker Cache pref in nightly
Depends on: 1110446
Depends on: 1110458
Depends on: 1110462
Depends on: 1110475
Depends on: 1110476
Depends on: 1110479
Depends on: 1110482
Depends on: 1110485
Depends on: 1110487
Depends on: 1110491
Depends on: cachetests
Depends on: 1100398
Depends on: 1107516
Depends on: 1110814
Depends on: 1112071
Depends on: 1112134
Depends on: 768074
Depends on: 1112922
Depends on: 1117808
Depends on: 1119864
Depends on: 1120496
Depends on: 1120501
Depends on: 1120505
Depends on: 1126818
Depends on: 1126819
Depends on: 1126820
Depends on: 1130452
Depends on: 1134671
No longer depends on: 768074
No longer depends on: 1110475
Depends on: 1119864
Depends on: 1140872
No longer depends on: 1110491
Depends on: 1145744
Depends on: 1146557
Summary: enable Service Worker Cache pref in nightly → ship Service Worker Cache in release builds
Depends on: 1146610
Depends on: 1147178
Depends on: 1147850
Depends on: 1147863
Depends on: 1147870
No longer depends on: 1147850
No longer depends on: 1147870
No longer depends on: 1147863
Alias: serviceworker
Alias: serviceworker → serviceworker-cache
Depends on: 1148818
Depends on: 1149987
Depends on: 1150001
Depends on: 1150505
Depends on: 1151892
Depends on: 1153470
Depends on: 1154325
Depends on: 1154531
No longer depends on: 1154531
Depends on: 1157286
Depends on: 1157287
No longer depends on: 1153470
Depends on: 1160138
Depends on: 1160147
Depends on: 1162365
Depends on: 1164524
Depends on: 1165395
No longer depends on: 1110476
No longer depends on: 1110479
No longer depends on: 1112134
No longer depends on: 1117808
No longer depends on: 1119864
No longer depends on: 1153183
No longer depends on: 1157287
No longer depends on: 1147178
No longer depends on: 1120505
Depends on: 1173439
No longer depends on: 1110458
Depends on: 1173467
Depends on: 1175138
Release Note Request (optional, but appreciated)
[Why is this notable]: Shipping Cache API
[Suggested wording]: Implemented Cache API for querying named caches that are accessible by a ServiceWorker
[Links (documentation, blog post, etc)]:
Standard:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-objects
MDN docs: https://developer.mozilla.org/en-US/docs/Web/API/CacheStorage
relnote-firefox: --- → ?
No longer depends on: 1145744
Comment on attachment 8626870 [details] [diff] [review]
Enable Cache API in release builds. r=ehsan

Review of attachment 8626870 [details] [diff] [review]:
-----------------------------------------------------------------

Congrats!
Attachment #8626870 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/f71f5a88e16d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #2)
> Release Note Request (optional, but appreciated)
> [Why is this notable]: Shipping Cache API
> [Suggested wording]: Implemented Cache API for querying named caches that
> are accessible by a ServiceWorker

Caches are accessible by non-Service Workers, too.  Ben, what do you think this should read?
Flags: needinfo?(lmandel)
Flags: needinfo?(bkelly)
I guess it could changed to:

  "Implemented Cache API for querying named caches that are accessible from window, Worker, and ServiceWorker."
Flags: needinfo?(bkelly)
Flags: needinfo?(lmandel)
I've updated browser compat information in the relevant articles:

https://developer.mozilla.org/en-US/docs/Web/API/CacheStorage (and member subpages)
https://developer.mozilla.org/en-US/docs/Web/API/Cache (and member subpages)

And added a note about it being exposed to window as well as worker.

I've also added a note here:

https://developer.mozilla.org/en-US/Firefox/Releases/41#Service_Workers
Blocks: 1183412
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10)
> I've also added a note here:
> 
> https://developer.mozilla.org/en-US/Firefox/Releases/41#Service_Workers

Just a note, the way that's written looks like Cache is behind the "experimental Service Worker implementation", and not totally clear it's actually shipping. Maybe it should be moved outside that bulleted list?
(In reply to Matt Falkenhagen from comment #11)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10)
> > I've also added a note here:
> > 
> > https://developer.mozilla.org/en-US/Firefox/Releases/41#Service_Workers
> 
> Just a note, the way that's written looks like Cache is behind the
> "experimental Service Worker implementation", and not totally clear it's
> actually shipping. Maybe it should be moved outside that bulleted list?

I think you've got a good point here. I've updated it as requested.
Depends on: 1192986
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.