1130522 - [META] IOS-30 - Security/Privacy - Clear private data

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/348

Sorry for the mess again. This is rebased from the old patch on top of your patch. I'm not sure how to make github show that correctly, so your changes are still appearing in here (as their own commit).

Comment 2

[Wesley Johnston (:wesj)]

I should note this doesn't interact with sync yet. There are enough interfaces between this and sync that I think we can fix that separately.

Comment 3

[Richard Newman [:rnewman]]

Yup, we'll tackle the Sync interaction when we come to implement syncing of these things!

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8594273 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/348

Comments on GH.

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8594273 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/348

Comments and an additional patch with changes on the PR. I also switched to using Deferred instead of callbacks here.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8594273 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/348

If you're sure that `Deferred<Result<Bool>>` is appropriate, go ahead.  I really think it should be either D<R<()>> or D<Bool>, though.

Comment 7

[Wesley Johnston (:wesj)]

Thanks for the void type hint.

Comment 8

[Francesco Lodolo [:flod]]

Noting also here: the string that landed doesn't make sense.

> Are you sure you want all of your data? This will also close all open tabs.

https://github.com/mozilla/firefox-ios/commit/0405c998435da0813da46426f7f7b9810a1942a1#diff-6209ecb7e871159425f66f16eed90d7dR276

I guess it's missing a "to clear/delete" after "want"?

Comment 9

[Stefan Plewako [:stef]]

"Clear private data setting" note doesn't help much (after reading it I still didn't know how the string is used) and should be updated.

https://github.com/mozilla/firefox-ios/commit/0405c998435da0813da46426f7f7b9810a1942a1#diff-6209ecb7e871159425f66f16eed90d7dR268

Comment 10

[Wesley Johnston (:wesj)]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/413

Updated these strings. Thanks for checking them flod :)

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8600521 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/413

Left a couple of nits for comments, but looks good, thanks.

Comment 12

[Wesley Johnston (:wesj)]

updated and merged. Thanks!