Closed Bug 1130522 Opened 5 years ago Closed 5 years ago

[META] IOS-30 - Security/Privacy - Clear private data

Categories

(Firefox for iOS :: General, defect, P2)

All
iOS 8
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jchaulk, Assigned: wesj)

References

Details

(Whiteboard: drop?)

Attachments

(2 files)

No description provided.
Priority: -- → P2
Assignee: nobody → sarentz
Whiteboard: drop?
Sorry for the mess again. This is rebased from the old patch on top of your patch. I'm not sure how to make github show that correctly, so your changes are still appearing in here (as their own commit).
Attachment #8594273 - Flags: review?(nalexander)
I should note this doesn't interact with sync yet. There are enough interfaces between this and sync that I think we can fix that separately.
Yup, we'll tackle the Sync interaction when we come to implement syncing of these things!
Assignee: sarentz → wjohnston
Status: NEW → ASSIGNED
Hardware: x86_64 → All
Comment on attachment 8594273 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/348

Comments and an additional patch with changes on the PR. I also switched to using Deferred instead of callbacks here.
Attachment #8594273 - Flags: feedback+ → review?(nalexander)
Comment on attachment 8594273 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/348

If you're sure that `Deferred<Result<Bool>>` is appropriate, go ahead.  I really think it should be either D<R<()>> or D<Bool>, though.
Attachment #8594273 - Flags: review?(nalexander) → review+
Thanks for the void type hint.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Noting also here: the string that landed doesn't make sense.

> Are you sure you want all of your data? This will also close all open tabs.

https://github.com/mozilla/firefox-ios/commit/0405c998435da0813da46426f7f7b9810a1942a1#diff-6209ecb7e871159425f66f16eed90d7dR276

I guess it's missing a "to clear/delete" after "want"?
"Clear private data setting" note doesn't help much (after reading it I still didn't know how the string is used) and should be updated.

https://github.com/mozilla/firefox-ios/commit/0405c998435da0813da46426f7f7b9810a1942a1#diff-6209ecb7e871159425f66f16eed90d7dR268
Depends on: 1157831
Depends on: 1157845
Depends on: 1157843
Updated these strings. Thanks for checking them flod :)
Flags: needinfo?(wjohnston)
Attachment #8600521 - Flags: review?(francesco.lodolo)
Comment on attachment 8600521 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/413

Left a couple of nits for comments, but looks good, thanks.
Attachment #8600521 - Flags: review?(francesco.lodolo) → review+
updated and merged. Thanks!
You need to log in before you can comment on or make changes to this bug.