Closed
Bug 1157843
Opened 11 years ago
Closed 11 years ago
TabManager memory leak
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: wesj, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #8596734 -
Flags: review?(bnicholson)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8596734 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/370
Results in a startup crash...
Attachment #8596734 -
Flags: review?(bnicholson) → review-
|
|
||
Comment 4•11 years ago
|
||
Note that bug 1157394 just landed, so for whatever fix we end up with here, let's make sure all of our ViewMemoryLeakTests are passing to verify.
|
|
||
Updated•11 years ago
|
Blocks: 1130522
tracking-fennec: --- → ?
Summary: WeakTabManagerDelegate should use weak references → TabManager memory leak
|
||
Updated•11 years ago
|
tracking-fennec: ? → +
|
|
Reporter | |
Comment 6•11 years ago
|
||
Updated to not crash the world.
Attachment #8596734 -
Attachment is obsolete: true
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 8600112 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/406
LGTM
Attachment #8600112 -
Flags: review+
|
|
||
Comment 8•11 years ago
|
||
Can you confirm all tests pass now with this fix?
|
|
Reporter | |
Comment 9•11 years ago
|
||
All the tests that pass for me (not all of them), pass after this as well. The about:home ones give me grief with and without this patch. I gave up on fixing that.
|
|
Reporter | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•