Attachment #8596734 - Flags: review?(bnicholson)
Comment on attachment 8596734 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/370 Results in a startup crash...
Attachment #8596734 - Flags: review?(bnicholson) → review-
Note that bug 1157394 just landed, so for whatever fix we end up with here, let's make sure all of our ViewMemoryLeakTests are passing to verify.
tracking-fennec: --- → ?
Summary: WeakTabManagerDelegate should use weak references → TabManager memory leak
Created attachment 8600112 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/406 Updated to not crash the world.
Attachment #8596734 - Attachment is obsolete: true
Comment on attachment 8600112 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/406 LGTM
Attachment #8600112 - Flags: review+
Can you confirm all tests pass now with this fix?
All the tests that pass for me (not all of them), pass after this as well. The about:home ones give me grief with and without this patch. I gave up on fixing that.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.