1130621 - [RTL][Settings] Wi-Fi Hotspot Security is center aligned which neither mirrors nor mimics LTR standard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Oliver Nelson [:oliverthor]]

Attachment: RTL_vs_LTR_hotspotSecurity.png

Description:
When the user observes the Wi-Fi Hotspot settings within their phone's Settings app, they will observe that the text formatting of that page doesn't appear completely mirrored: 

PreReq:
* language set to RTL (Arabic)
Repro Steps:
1) Update a Flame to 20150206010204
2) Open the Settings app.
3) Navigate to Internet Sharing.
4) Observe alignment of Security Text.

Actual:
Security text is center aligned.

Expected:
Security text is left aligned to mirror LTR (and match Hotspot name formatting).


Environmental Variables:
--------------------------------------------------
Device: Flame 3.0
Build ID: 20150206010204
Gaia: af646d92e4bb8a1b1afe1feba9d51229445aaf40
Gecko: 7c5f187b65bf
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Device: Flame 2.2
BuildID: 20150206002505
Gaia: a52999ce7f783177deb17e267bf003a53e6fde06
Gecko: 01446d5231ef
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------

Repro frequency: 4/4
See attached: 
screenshot (3.0 RTL, 2.2 RTL, 3.0 LTR comparison shot)

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] EragonJ:bug-1130621 to mozilla-b2g:master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8561181 [details] [review]
[PullReq] EragonJ:bug-1130621 to mozilla-b2g:master

Arthur can you help me review this simple patch ? Thanks !

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8561181 [details] [review]
[PullReq] EragonJ:bug-1130621 to mozilla-b2g:master

r=me, thanks.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur, this patch was merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/5c5d9266306a0f0ce9391003e804edd54d7e88f6

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8561181 [details] [review]
[PullReq] EragonJ:bug-1130621 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: Fixed the order of wifi security in RTL languages
[Testing completed]: no, only CSS change
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/778f33cf01c3d3d4643f2434fc25c31930078e72

Comment 7

[Coler]

Hi Eric,
  This issue has been verified successfully on Flame 2.2/3.0, but the '()' isn't displayed correctlly.
Could you help to confirm it? Keeping in this bug or filing a new one? Thnnks!

Attachment:Verify_RTL_Sharenetwork.png.

Flame 2.2:

Gaia-Rev        791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/dcf030ef499d
Build-ID        20150211162505
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150211.194909
FW-Date         Wed Feb 11 19:49:19 EST 2015
Bootloader      L1TC000118D0

Flame 3.0:

Gaia-Rev        e280a660955bbdab265d50f8d9e009de34082332
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/650863f6987b
Build-ID        20150211160231
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150211.192431
FW-Date         Wed Feb 11 19:24:42 EST 2015
Bootloader      L1TC000118D0

Comment 8

[Coler]

Attachment: Verify_RTL_Sharenetwork.png

Comment 9

[Eric Chang [:ericcc] [:echang]]

Reproducible in today's build.

Alignment okay,
But the parentheses is not correct.

(In reply to Coler from comment #8)
> Created attachment 8563299 [details]
> Verify_RTL_Sharenetwork.png

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Coler, please check bug 1125069 for more information. 

In that bug, we already told Sue that the problem about parenthesis should be fixed after the l10n change is picked up. But I think this information is not quite clear there for mgsei team. Can you help to propagate this information to other teammates to make sure we won't make dup bugs for this case ?

Thanks !

Comment 11

[Coler]

Thank you, EJ!!

Comment 12

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15672/