Closed Bug 1130791 Opened 9 years ago Closed 9 years ago

Only install toString and valueOf forwarders on classes that need them

Categories

(Firefox Graveyard :: Shumway, defect)

Product:
Firefox Graveyard
Component:
Shumway
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: till, Unassigned)

References

Details

During jwplayer.flash.swf's startup, we call forwardValueOf more than 3000 times and forwardToString almost 2400 times. Given that they'll be called from lots of different places, probably not a single one of these calls is inlined, meaning we take the hit of the indirection every single time.

I think what we can do is only install them on the prototype of ASObject or, even better, only on classes that actually define a public valueOf or toString method.
The whole forwarder mechanism doesn't exist anymore.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.