1130828 - Fix clang -Widiomatic-parentheses and -Wsemicolon-before-method-body warnings

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Widiomatic-parentheses.patch

These particular warning instances are harmless, but they are the only instances of these warnings in the tree, so it be nice to fix them on the path to zero warnings. :)

> dom/system/mac/CoreLocationLocationProvider.mm:47:12 [-Widiomatic-parentheses] using the result of an assignment as a condition without parentheses
> widget/cocoa/nsMenuBarX.mm:752:12 [-Widiomatic-parentheses] using the result of an assignment as a condition without parentheses
> widget/cocoa/nsMenuBarX.mm:761:12 [-Widiomatic-parentheses] using the result of an assignment as a condition without parentheses

> widget/cocoa/nsCocoaWindow.mm:3349:81 [-Wsemicolon-before-method-body] semicolon before method body is ignored
> widget/cocoa/nsMenuBarX.mm:800:70 [-Wsemicolon-before-method-body] semicolon before method body is ignored

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8560978 [details] [diff] [review]
Widiomatic-parentheses.patch

This looks fine to me.

-- (NSPoint)fullScreenButtonPositionWithDefaultPosition:(NSPoint)aDefaultPosition;
+- (NSPoint)fullScreenButtonPositionWithDefaultPosition:(NSPoint)aDefaultPosition

-- (void)_performActionWithHighlightingForItemAtIndex:(NSInteger)index;
+- (void)_performActionWithHighlightingForItemAtIndex:(NSInteger)index

It's interesting that Apple has finally decided to warn about this particular error.  For years they silently fixed it.

Comment 2

[Chris Peterson [:cpeterson]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f575d77835

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9f575d77835