1130920 - MSE addSourceBuffer stops due to PRELOAD_NONE is true on gonk pref.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Alfredo Yang (:alfredo)]

test item 3 on:
http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2015.html?timestamp=1423451570079


reason:
https://dxr.mozilla.org/mozilla-central/source/dom/html/HTMLMediaElement.cpp?from=HTMLMediaElement.cpp&case=true#867

The pref value of PRELOAD_NONE is true on gonk pref. We need to skip that when the source is from MSE.

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: skip_pref_preload_on_gonk

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8563868 [details] [diff] [review]
skip_pref_preload_on_gonk

Review of attachment 8563868 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLMediaElement.cpp
@@ +1078,5 @@
>    } else {
>      // Find the appropriate preload action by looking at the attribute.
>      const nsAttrValue* val = mAttrsAndChildren.GetAttr(nsGkAtoms::preload,
>                                                         kNameSpaceID_None);
> +    // MSE doesn't work if repload is none, so it igonres the pref when src is

s/repload/preload/
s/igonres/ignores/

Comment 3

[Alfredo Yang (:alfredo)]

Attachment: skip_pref_preload_on_gonk

Thanks for review.

Comment 4

[Alfredo Yang (:alfredo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd957c3d6b27

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c598faec1736

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c598faec1736