1131023 - Add a button to enter private browsing in the browser

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Kevin Grandon :kgrandon]

We should eventually convert the page to a private browsing instance. For now, we can just trigger the new page.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8561365 [details] [review]
[PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to mozilla-b2g:master

Mike - could you review this?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8561365 [details] [review]
[PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to mozilla-b2g:master

I left a couple of comments on github. I also think we might be missing the IAC listener in the system app for opening a new private window when getting the private-window message. In any case, when I click the button currently it does not open the window.

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Michael Henretty [:mhenretty] from comment #3)
> Comment on attachment 8561365 [details] [review]
> [PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to
> mozilla-b2g:master
> 
> I left a couple of comments on github. I also think we might be missing the
> IAC listener in the system app for opening a new private window when getting
> the private-window message. In any case, when I click the button currently
> it does not open the window.

Sorry, this was bug 1131024, which autolander is currently trying to land. I will re-request review once it's in :)

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8561365 [details] [review]
[PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to mozilla-b2g:master

Mike - the system app changes should now be in the latest master, I've also addressed most of the github comments. Can you take a look again and let me know?

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8561365 [details] [review]
[PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to mozilla-b2g:master

Works like a charm.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6d1fb2013844559fe91333e57ad98d9625bee069

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8561365 [details] [review]
[PullReq] KevinGrandon:bug_1131023_enter_private_browsing_window to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: No easy way to launch private browsing.
[Testing completed]: Manual and integration tests.
[Risk to taking this patch] (and alternatives if risky): This is mainly just layout work and is fairly low risk.
[String changes made]: Yes

(Note: both commits need to be uplifted)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/db33f76884094a3177dbac8cba2967c94884832f

Comment 10

[Kevin Grandon :kgrandon]

I think we were missing one commit here from the PR (received approval), so I've gone ahead and uplifted it: https://github.com/mozilla-b2g/gaia/commit/fce8778937e1d57d1da9458d1205a0bd95e0e93e

(This probably should've been split into its own bug, but it landed here.)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

So I do usually check for multiple commits when doing uplifts, but usually that's from a merged PR and it's clear when there's more than one. With Autolander, I'm just getting a single revision posted in the bug. How should I be properly checking for this in the future?

Comment 12

[Kevin Grandon :kgrandon]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #11)
> So I do usually check for multiple commits when doing uplifts, but usually
> that's from a merged PR and it's clear when there's more than one. With
> Autolander, I'm just getting a single revision posted in the bug. How should
> I be properly checking for this in the future?

Ok, thanks for the feedback. I didn't realize it, but it looks like this is definitely a bug with autolander. I've filed bug 1132066 for this and will try to get to it asap.

Comment 13

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: "Private Window" button exists and functions properly on the new window page on Browser.
 
Device: Flame Master (319mb, full flash)
Build ID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
================================
leaving verifyme for 2.2 verification.

Comment 14

[Lance（leave from Mozilla）]

Attachment: Verify_video .mp4

The problem is verified not happen on latest Flame 2.2 build.

Steps:
1. Open browser.
2. Tap Private Window button.
3. Tap "..." and new a window.
4. Tap Private Window button.

Actual Result:
1. 3.Exist a "Private Window" button on the new window page of Browser.
2. 4."Private Window" button work properly.

Fail rate:0/10
See attachment:Verify_video.MP4

Flame 2.2 version:
Build ID               20150211002505
Gaia Revision          943be6fd146017dcd9d4c9d1027be1e43bad13eb
Gaia Date              2015-02-11 08:01:09
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e614443583e7
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150211.040242
Firmware Date          Wed Feb 11 04:02:53 EST 2015
Bootloader             L1TC000118D0