Closed Bug 1131106 Opened 9 years ago Closed 9 years ago

Add-on options header is visible even if there are no valid options

Categories

(Firefox for Android Graveyard :: Add-on Manager, defect)

Product:
Firefox for Android Graveyard
Component:
Add-on Manager
Version:
35 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 unaffected, firefox36 unaffected, firefox37 verified, firefox38 verified, fennec37+)

Status:
VERIFIED FIXED
Milestone:
Firefox 38
Tracking Flags:
Tracking Status
firefox35 --- unaffected
firefox36 --- unaffected
firefox37 --- verified
firefox38 --- verified
fennec 37+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1131106 - Hide options header in add-on details view if there are no valid options. r=mfinkle
39 bytes, text/x-review-board-request
mfinkle
: review+
Details 
This issue is visible with the OpenH264 plugin. We should hide the options header if there are no visible options in the add-on detail page.
tracking-fennec: --- → ?
/r/3589 - Bug 1131106 - Hide options header in add-on details view if there are no valid options. r=mfinkle

Pull down this commit:

hg pull review -r a84e22c11b188c3a95e7a0dc49584adef759245c
Attachment #8561467 - Flags: review?(mark.finkle)
Comment on attachment 8561467 [details]
MozReview Request: bz://1131106/margaret

https://reviewboard.mozilla.org/r/3587/#review2819

Ship It!
Attachment #8561467 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/3b25c782402c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Comment on attachment 8561467 [details]
MozReview Request: bz://1131106/margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1110271
[User impact if declined]: odd-looking "options" header appears in OpenH264 plugin listing in add-on manager
[Describe test coverage new/current, TreeHerder]: tested locally, landed in m-c
[Risks and why]: low-risk, adds check to hide "options" header if there are no options
[String/UUID change made/needed]: none
Attachment #8561467 - Flags: approval-mozilla-aurora?
Based on the latest patches to land in bug 1110271, I think this impacts 37+.
status-firefox35: --- → unaffected
status-firefox36: --- → unaffected
status-firefox37: --- → affected
Comment on attachment 8561467 [details]
MozReview Request: bz://1131106/margaret

Simple fix for UI polish. I verified the fix on Nightly on my Nexus 5. Aurora+
Attachment #8561467 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in Firefox for Android 38.0a1 (2015-02-11);
Device: Asus Transformer Pad TF300T (Android 4.2.1).
status-firefox38: fixed → verified
tracking-fennec: ? → 37+
Verified as fixed in Firefox 37 Beta 1;
Devices: Samsung Galaxy R (Android 2.3.4) and Google Nexus 7 (Android 5.0.2).
Status: RESOLVED → VERIFIED
status-firefox37: fixed → verified

        Attachment #8561467 -
        Attachment is obsolete: true

        Attachment #8619411 -
        Flags: review+

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: