1131246 - [RTL] [Dialer] "+" symbol is shown on the wrong side of the Callscreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Doug Sherk (:drs) (inactive)]

See bug 1102340 comment 12.

Comment 1

[bhavana bajaj [:bajaj]]

Coler, can you give specific STR for the missed case you found in 1102340, in this bug ? Thanks!

Comment 2

[Coler]

Hi bhavana,
   The STRs are:
Prerequisite:Insert a SIM card, set system language to Arabic.
  STR:
 1) Launch Phone.
 2) Dial a phone number(like:[phone]).
 3) Tap call button,check the dialing view.

Actual Result:The phone number is displayed as 86123456+.

Excepted Result: The phone number should be displayed as [phone].
Hope this can help you. Thanks.

Comment 3

[bhavana bajaj [:bajaj]]

Thanks hoping :drs or someone in dialer can take this now :)

Comment 4

[Stephany Wilkes]

How is this looking for FL on Monday?

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

Comment 6

[Tamara Hills [:thills]]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

Hi Doug,

Here's something for feedback since we went back and forth on this a bit.  I believe it's mostly working but I want to do bit more testing on this and also make sure this is in line.

Thanks,

-tamara

Comment 7

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

This approach is good.

Comment 8

[Tamara Hills [:thills]]

Attachment: secondincoming.png

Comment 9

[Tamara Hills [:thills]]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

Hi Doug,

I wound up having to make a few more changes into the ConferenceGroupDetails overlay due to the bdi node.

thanks,

-tamara

Comment 10

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

See my comments on the PR.

Comment 11

[Tamara Hills [:thills]]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

Hi Doug,

I changed the font tests around a little bit to include the bdi case for the other existing tests.  Thanks for the review.
-tamara

Comment 13

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

This needs another iteration. We're getting close, though.

Comment 14

[Tamara Hills [:thills]]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

Hi Doug,

Thank you for the simplifications.  Was helpful.

Thanks,

-tamara

Comment 15

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

Looks good, but this needs a better commit message. I also left a comment on the PR.

Comment 16

[Tamara Hills [:thills]]

try:  https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=cef769cd3c33040e701a058d672cfca2af7eeead

commit:  https://github.com/mozilla-b2g/gaia/commit/e9ea06721410a7b02ce6cd72e38a11b7262556de

Comment 17

[Sue]

Attachment: callscreen.png

This issue has been verified successfully on latest build of Flame 3.0 with the same steps in comment 2. The "+" symbol is shown on the left side of the phone number at callscreen(such as "+8610010").
See attachment:callscreen.png
Rate:0/5

Device: Flame 3.0 (pass)
Build ID               20150329010203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.042104
Firmware Date          Sun Mar 29 04:21:16 EDT 2015
Bootloader             L1TC000118D0

Comment 18

[Tamara Hills [:thills]]

Comment on attachment 8567423 [details] [review]
[gaia] tamarahills:bugfix/1131246-fixplus-callscreen-rtl > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): RTL feature
[User impact] if declined: User would see the + on the wrong side on the call screen
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low-medium
[String changes made]: none

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/7a1d76dab2f662584dd30aad54aa047d2369cdde

Comment 20

[Sue]

Attachment: v2.2_verify.png

This issue has been verified successfully on latest build of Flame 2.2 with the same steps in comment 2. The "+" symbol is shown on the left side of the phone number at callscreen(such as "[phone]").
See attachment:v2.2_verify.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150401002624
Gaia Revision          8b3086ad3963f1707e2bee9094baccafffe161c4
Gaia Date              2015-03-31 21:48:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20b67213a047
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150401.042225
Firmware Date          Wed Apr  1 04:22:36 EDT 2015
Bootloader             L1TC000118D0