1102340 - "+" symbol is shown on the wrong side of phone numbers

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

The "+" symbol is currently shown on the wrong side of phone numbers in RTL mode.

Bug 1080828 should provide us with some useful guidance here.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot 2

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Sorry for bugging Doug, but I need to know if someone's working on this? :)
Thanks!

Comment 3

[Doug Sherk (:drs) (inactive)]

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #2)
> Sorry for bugging Doug, but I need to know if someone's working on this? :)
> Thanks!

Nope, feel free to take it.

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1102340 to mozilla-b2g:master

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8542518 [details] [review]
[PullReq] anefzaoui:bug-1102340 to mozilla-b2g:master

Three unit tests are failing here, so please fix them, but the approach looks good.

Comment 6

[Dylan Oliver [:doliver]]

Carrying over blocking/priority from similar bug 1058790.

Comment 7

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27061

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

Gaia is now open.

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/0c19464938a9bdf49e17972d5f6a2275b93df26b

Comment 10

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8542518 [details] [review]
[PullReq] anefzaoui:bug-1102340 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Lack of RTL support
[User impact] if declined: attachment 8526109 [details]
[Testing completed]: Yes, Device: Flame
[Risk to taking this patch] (and alternatives if risky): No risks, tests passing
[String changes made]: No string changes made

Comment 11

[Fabien Cazenave [:kaze]]

Uplifted to 2.2: https://github.com/mozilla-b2g/gaia/commit/97d7cae

Comment 12

[Coler]

Hi Doug, 
   On Flame 2.2&3.0, I verify this issue in Call log view and Call information view, "+" symbol is shown on the left side(Verify_RTL_Call Information.png and Verify_RTL_Call log.png).But in dialing view,it is sitll shown on the right side, please see attachments:Verify_RTL_Dailing.png.Did it verify failed? Could you help me to confirm it? Thanks.
Reproduce rate:5/5
Foundtime:11:35
Attachment:Verify_RTL_Call Information.png,Verify_RTL_Call log.png, Verify_RTL_Dailing.png,logcat_1135.txt

Flame 2.2 build:

Gaia-Rev        6e494f1d2676d231abba7dcc2e2822d1170d2d02
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5e6fac01a72f
Build-ID        20150129003432
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150129.042943
FW-Date         Thu Jan 29 04:29:53 EST 2015
Bootloader      L1TC000118D0

Flame 3.0 build:

Gaia-Rev        9d2378a9ef092ab1fc15c3a9f7fc4171aab59d57
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/6bfc0e1c4b29
Build-ID        20150129010239
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150129.043711
FW-Date         Thu Jan 29 04:37:21 EST 2015
Bootloader      L1TC000118D0

Comment 13

[Coler]

Attachment: logcat_1135.txt

Comment 14

[Coler]

Attachment: Verify_RTL_Call Information.png

Comment 15

[Coler]

Attachment: Verify_RTL_Call log.png

Comment 16

[Coler]

Attachment: Verify_RTL_Dailing.png

Comment 17

[Doug Sherk (:drs) (inactive)]

(In reply to Coler from comment #12)

Thanks, good catch. I've filed bug 1131246 for this issue.

Comment 18

[Coler]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #17)
> (In reply to Coler from comment #12)
> 
> Thanks, good catch. I've filed bug 1131246 for this issue.

Thanks, Doug!

Comment 19

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/155521/

Comment 20

[Johan Lorenzo [:jlorenzo]]

This issue was reproduced on the Flame initially.

Comment 21

[Norry.L.F(Leave from Mozilla)]

According to comment 12 & comment 17, this bug is fixed, new bug is tracked on bug 1131246, so close this bug.