1131393 - The Reader Mode view of Bugzilla seems to pick out arbitrary comments

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Enable about:config pref "reader.parse-on-load.enabled"
 2. Visit https://bugzilla.mozilla.org/show_bug.cgi?id=724432
 3. Click the reader-mode icon in URL bar.

ACTUAL RESULTS:
The reader mode page starts out with the title (good), and then has an arbitrary-seeming selection of the bug's comments. In particular, it has:
 - bug 724432 comment 3 ("Is this something we think we can reinstate later, or is there some fundamental issue with it?")
 - bug 724432 comment 6 ("Please file a new bug.  This bug is only for making [...]")
 - bug 724432 commment 8 ("Created Attachment[...] The full diff for[...]")

It's unclear why comments 1, 2, 4, 5, & 7 are skipped.

EXPECTED RESULTS:
All of the comments should be there in the reader-mode view. No clear reason why these particular comments should be skipped.

Comment 1

[:Margaret Leibovic]

It actually seems like the real fix here is bug 784653, which would prevent us from even offering reader mode on bugzilla.

Comment 2

[:Gijs (he/him)]

This is better now but still not great. :-(

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to :Gijs Kruitbosch from comment #2)
> This is better now but still not great. :-(

(are you sure it's better? I still see the same ACTUAL RESULTS described in comment 0)
(Though this doesn't matter much, given bug 784653.)

Comment 4

[:Gijs (he/him)]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > This is better now but still not great. :-(
> 
> (are you sure it's better? I still see the same ACTUAL RESULTS described in
> comment 0)
> (Though this doesn't matter much, given bug 784653.)

Sorry, I should have been more articulate. We landed stuff on fx-team (not in nightly yet, but should be on an m-c build from the last hour or two) which seems to have improved this on random bugzilla pages that I used to test. Checking your testcase, it does indeed seem to show more comments than it used to, but still not all of them.

Comment 5

[:Gijs (he/him)]

Reader mode is no longer offered on bugzilla.

Comment 6

[:Margaret Leibovic]

I also tried reproducing this by manually forcing reader view from the browser console, and it looked like we didn't pick out any comments, so the Readability.js logic has probably changed since this was filed.