Closed Bug 724432 Opened 8 years ago Closed 8 years ago

Backout nsChangeHint_UpdateOverflow for all properties except transforms. (bug 719177 etc)

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13
Tracking Status
firefox12 + fixed

People

(Reporter: mats, Assigned: mats)

Details

(Whiteboard: [qa-])

Attachments

(4 files)

Attached patch additional fixesSplinter Review
Additional fixes on top of the backout, as requested in bug 723669.
Is this something we think we can reinstate later, or is there some fundamental issue with it?
Comment on attachment 594602 [details] [diff] [review]
additional fixes

Review of attachment 594602 [details] [diff] [review]:
-----------------------------------------------------------------

Should we remove nsChangeHint_UpdateTransformLayer and nsChangeHint_UpdateOpacityLayer too? I think we should! It seems to me they currently have the same bug.
Please file a new bug.  This bug is only for making UpdateOverflow work for
transforms and nothing else.  The aim is to merge this to Aurora and leave it
at that state for Fx12.  Then re-land bug 719177 with some additional fixes
(as discussed in bug 723669) on trunk, except for 'text-shadow' which we can
handle in bug 723669 (if we decide to do it).
The Try run was green.  I installed the Try build on my Nexus and it seems to work
fine on sites mentioned in bug 722325, but I'm not exactly sure what to look for.

Chris, I'd appreciate if you can verify that.
https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mpalmgren@mozilla.com-fa1a77db5788/
Feel free to review this patch, or the backout commands + additional fixes
patch, whichever you think is easier to review.
Attachment #594799 - Flags: review?(roc)
(In reply to Mats Palmgren [:mats] from comment #6)
> Please file a new bug.

Sure, filed bug 724502. I'll try to fix it.
Attachment #594799 - Flags: review?(roc)
This caused bug 722325 to regress again, so I re-instated that wallpaper and
filed bug 725664 to fix it for real.  The question is - what do we want to do
for Aurora?  Ship with the wallpaper or revert UpdateOverflow also for transforms?
Attached file backout for Aurora
Ok, here's the backout commands for Aurora.  Specifically, I'm NOT backing out
the wallpaper for bug 722325, which landed independently for Aurora in
https://hg.mozilla.org/releases/mozilla-aurora/rev/73f3d8eeb937

On top of that, the same "additional fixes" patch.
These changes will make the affected code the same as currently on trunk.
Comment on attachment 596226 [details]
backout for Aurora

[Approval Request Comment]
Regression caused by (bug #): 722117, 719177, 524925 (part 4)
User impact if declined: content rendering errors
Testing completed (on m-c, etc.): baked on trunk for a few days,
pass reftests in local Aurora build on Linux, Try results pending:
https://tbpl.mozilla.org/?tree=Try&rev=40d3b4e37a0e
Risk to taking this patch (and alternatives if risky): low since it mostly
reverts changes from the mentioned bugs
String changes made by this patch: none
Attachment #596226 - Flags: approval-mozilla-aurora?
Depends on: 726912
Comment on attachment 596226 [details]
backout for Aurora

[Triage Comment]
Approving these backouts for Aurora 12 given the content rendering regressions.
Attachment #596226 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer depends on: 726912
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.