1131486 - [RTL][Download Manager]The position of checkboxes are not mirrored in downloads list.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Sue]

Attachment: checkbox.png

[1.Description]:
[RTL][Download Manager]When you tap menu button at downloads list, the checkboxes are not mirrored and they are displayed at left of screen.
See attachment:checkbox.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic.
1. Launch Browser.
2. Download some files from https://owd.tid.es/dm/.
3. Tap on the download start notification.
4. Tap menu button at top right. 

[3.Expected Result]: 
4. The checkboxes should be mirrored and displayed at right of screen.

[4.Actual Result]: 
4. The checkboxes are not mirrored.

[5.Reproduction build]: 
Flame 2.2 build:
Build ID               20150209002504
Gaia Revision          e827781324cbde91d2434b388f5dead3303a85ee
Gaia Date              2015-02-06 20:54:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0552759956d3
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150209.040038
Firmware Date          Mon Feb  9 04:00:51 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Norry.L.F(Leave from Mozilla)]

Update the expected result: 4. The position of checkboxes should be mirrored and it should display at right of screen.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Ahmed, in bug 833401 it looks like we explicitly made the downloads list display in LTR mode even when the language is RTL [1]. Is this to spec, and if so is this bug invalid?

1.) https://github.com/mozilla-b2g/gaia/commit/c7048a521bc07f4e45664992ba46f4a196ddb746#diff-5cb1917b2f34c7e6ca11361714b980a7R266

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

I spoke with Ahmed on IRC, and he believes this is according to spec (since file extensions never display in RTL). Can you confirm what the correct behavior should be for the download screen here? Ie. should we be mirroring the check boxes and text?

Comment 4

[Stephany Wilkes]

Based on the bidi pattern, here's what I'd expect to see here (and I also consulted with Francis Djabri, who speaks some Arabic as well). This refers to page 19 of the pattern (see https://mozilla.box.com/s/bcm3s5i2v6js5uk0ws3tsywse8bgncgo), and would apply in both Arabic and English cases (i.e. cases in which a file name is in Arabic).

* All text is aligned right, whether English or Arabic.
* Check boxes are always on the right.

Please flag me if any clarification is needed - happy to help as we can.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1131486-rtl-download-checkboxes > mozilla-b2g:master

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564543 [details] [review]
[gaia] mikehenrty:bug-1131486-rtl-download-checkboxes > mozilla-b2g:master

EJ, can you have a look here?

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8564543 [details] [review]
[gaia] mikehenrty:bug-1131486-rtl-download-checkboxes > mozilla-b2g:master

these codes look okay to me. Please help to attach a screenshot and ni? visual for ui-review. I think Helen would be the best one to help this.

Thanks !!

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] rtl download checkbox

Helen, how does this look?

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564947 [details]
[screenshot] rtl download checkbox

Since Chinese New Year is coming up, I'm not sure if Helen will be able to look at this before FL. Stephany, would you mind taking a look here?

Comment 12

[Stephany Wilkes]

Comment on attachment 8564947 [details]
[screenshot] rtl download checkbox

Looks good to me. The checkbox is in the correct place. Also adding a feedback? for Kaze to double check the string and order-of-appearance for the numerals within the Arabic string.

Comment 13

[Fabien Cazenave [:kaze]]

Looks good to me as well.

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks everyone!

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2f2037d1bafb9b527e6e6e994a90f2d1d43d7ede

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564543 [details] [review]
[gaia] mikehenrty:bug-1131486-rtl-download-checkboxes > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL feature.

[User impact] if declined:
The download list will look very strange in RTL mode.

[Testing completed]:
Manual testing.

[Risk to taking this patch] (and alternatives if risky):
Css only patch effecting RTL specifically. Low risk.

[String changes made]: none.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/7fbc4435e89d7b8d8500c8f0e3fe3e9b5ad10129

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly  Flame KK 3.0 and 2.2 builds.

Actual Results: The check box is on the right now.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 KK (Full Flash) (319 MB)
BuildID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 20

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15751/