Closed Bug 1131552 Opened 6 years ago Closed 6 years ago

[FFOS2.0][Woodduck][STK][Refresh]MS can't refresh MSISDN successful

Categories

(Firefox OS Graveyard :: Gaia, defect, P2)

defect

Tracking

(blocking-b2g:2.0M+, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 ?, b2g-master ?)

RESOLVED FIXED
2.2 S6 (20feb)
blocking-b2g 2.0M+
Tracking Status
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- ?
b2g-master --- ?

People

(Reporter: sync-1, Assigned: selee)

References

Details

Attachments

(8 files)

DEFECT DESCRIPTION:
 ->MS can't refresh MSISDN successful after perform refresh MSISDN
 
  REPRODUCING PROCEDURES:
 ->MS load simulated SIM card and SATK application which can send "Refresh" procative SIM command.
 ->Enter into "Settings->Commandes Proactives->Refresh->STN07002->MSISDN"
 ->Observe My Number in settings after refresh MSISDN
 
  EXPECTED BEHAVIOUR:
 ->MS should refresh MSISDN successful after perform refresh MSISDN
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:
 
 +86 151 1324 9081
Attached file mtklog 907795
Attached file sdn
Hi Sean,
Could you please help to check the problem? Thanks!
Flags: needinfo?(selee)
Hi Mozilla,
  please ignore the first log. In the second log, we find msisdn has updated. But at settings->Device Information->Phone number, not update the number when execute refresh command to refresh MSISDN. Could you please help to update the number? Thank you.

old value:
"msisdn":"11001894790"
new value:
"msisdn":"0155663140"

--------------------log start--------------------
        Line 7868: 02-09 03:54:44.023   162   162 I Gecko   : -*-
RadioInterface[0]: Received message from worker:
{"iccType":"sim","iccid":"89441000000400617452","rilMessageType":"iccinfochange","rilMessageClientId":0,"mcc":"001","mnc":"01","ons":"Operateur
Name
String","ons_short_form":"FNAC","isDisplayNetworkNameRequired":true,"isDisplaySpnRequired":true,"msisdn":"11001894790","spn":"Vodafone"}
        Line 7877: 02-09 03:54:44.190   162   630 I Gecko   : RIL Worker: [0]
readingSST:MSISDN:
        Line 7878: 02-09 03:54:44.191   162   630 I Gecko   : RIL Worker: [0]
MSISDN: MSISDN is available
        Line 7878: 02-09 03:54:44.191   162   630 I Gecko   : RIL Worker: [0]
MSISDN: MSISDN is available
        Line 8105: 02-09 03:54:46.044   162   630 I Gecko   : RIL Worker: [0]
MSISDN: 0155663140
        Line 8107: 02-09 03:54:46.048   162   162 I Gecko   : -*-
RadioInterface[0]: Received message from worker:
{"iccType":"sim","iccid":"89441000000400617452","rilMessageType":"iccinfochange","rilMessageClientId":0,"mcc":"001","mnc":"01","ons":"Operateur
Name
String","ons_short_form":"FNAC","isDisplayNetworkNameRequired":true,"isDisplaySpnRequired":true,"msisdn":"0155663140","spn":"Vodafone"}
--------------------log end--------------------------
Hi Pengfei,

Will Phone number in Settings app be shown correctly after rebooting the phone?
Flags: needinfo?(selee)
(In reply to Sean Lee [:seanlee] from comment #5)
> Hi Pengfei,
> 
> Will Phone number in Settings app be shown correctly after rebooting the
> phone?
  Yes, it's correct after rebooting.
Sean, per comment 6 the phone number in Settings app is correct after reboot.
Flags: needinfo?(selee)
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(selee)
Resolution: --- → DUPLICATE
Duplicate of bug: 1132363
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Hi Pengfei,

Could you help to test the trail patch? Thank you.
Flags: needinfo?(pengfei.huang.hz)
Attached file mtklog_SDN_PASS.zip
Hi Sean,
  we see the Phone number changed. Test pass.
  Nice patch. Thank you very much.
Flags: needinfo?(pengfei.huang.hz)
Hi Pengfei,

Could you help to try this patch again?
This one is simpler and removed debug messages.
Thank you.
Flags: needinfo?(pengfei.huang.hz)
Assignee: nobody → selee
Status: REOPENED → ASSIGNED
Hi Sean,
  Yeah, patch works well. Pass the test.
Flags: needinfo?(pengfei.huang.hz)
Attached file PR for v2.0m
Hi Arthur,

Could you help to review this patch for v2.0m?
Thank you.
Attachment #8563932 - Flags: review?(arthur.chen)
Comment on attachment 8563932 [details] [review]
PR for v2.0m

Good job! r=me.
Attachment #8563932 - Flags: review?(arthur.chen) → review+
Arthur, Thank you!

landed on v2.0m : https://github.com/mozilla-b2g/gaia/commit/a1b5959728c8bc2a82354e197bb161922d419866
Status: ASSIGNED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Comment on attachment 8563932 [details] [review]
PR for v2.0m

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):

[User impact] if declined:
Phone Number in Settings/About will not be updated when msisdn or mdn is changed.

[Testing completed]:
1. Partner tested PASS in their LAB.
2. Unit test tested PASS.

[Risk to taking this patch] (and alternatives if risky):
Only changed at Settings app. Very minor risk.

[String changes made]:
None
Attachment #8563932 - Flags: approval-gaia-v2.1?
Attachment #8563932 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
v2.1: https://github.com/mozilla-b2g/gaia/commit/5d3479fdd438412adee4452720856b6b771fe5cd

Are v2.2/v3.0 unaffected?
status-b2g-v2.2: --- → ?
Flags: needinfo?(selee)
Target Milestone: --- → 2.2 S6 (20feb)
Hi Ryan,

Thanks for your concern.

This patch is tested by TCL on v2.0m, and v2.1 has the same architecture. I think there is no much risk to cherry-pick to v2.1.

Settings app has a lot of architecture changes on v2.2/v3.0, so we need to discuss if it's really affected to v2.2/v3.0.

Hi Arthur,

Do you think this issue is affected to v2.2/v3.0?
IMHO, we need to listen event 'iccinfochange' and invoke '_loadHardwareInfo' to update the information.
I think the modification would be in HardwareInfo.prototype.init .
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/about/hardware_info.js#L29

Do you have any suggestions?

Thank you!
Flags: needinfo?(selee)
Flags: needinfo?(arthur.chen)
Yes, the change should be made to the code you mentioned. The only difference would be in v2.2 and 3.0 it is discouraged to use IccHelper as it is planned to be deprecated. Please use SimSlotManager in the shared folder instead.
Flags: needinfo?(arthur.chen)
blocking-b2g: --- → 2.0M+
Dear Wayne Teng,
   we can close this bug, please see TCL bug907795.
   Thanks.
You need to log in before you can comment on or make changes to this bug.