1131552 - [FFOS2.0][Woodduck][STK][Refresh]MS can't refresh MSISDN successful

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[sync-1]

DEFECT DESCRIPTION:
 ->MS can't refresh MSISDN successful after perform refresh MSISDN
 
  REPRODUCING PROCEDURES:
 ->MS load simulated SIM card and SATK application which can send "Refresh" procative SIM command.
 ->Enter into "Settings->Commandes Proactives->Refresh->STN07002->MSISDN"
 ->Observe My Number in settings after refresh MSISDN
 
  EXPECTED BEHAVIOUR:
 ->MS should refresh MSISDN successful after perform refresh MSISDN
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:
 
 [phone]

Comment 1

[sync-1]

Attachment: mtklog 907795

Comment 2

[sync-1]

Attachment: sdn

Comment 3

[Josh Cheng [:josh]]

Hi Sean,
Could you please help to check the problem? Thanks!

Comment 4

[pengfei.huang]

Hi Mozilla,
  please ignore the first log. In the second log, we find msisdn has updated. But at settings->Device Information->Phone number, not update the number when execute refresh command to refresh MSISDN. Could you please help to update the number? Thank you.

old value：
"msisdn":"11001894790"
new value：
"msisdn":"0155663140"

--------------------log start--------------------
        Line 7868: 02-09 03:54:44.023   162   162 I Gecko   : -*-
RadioInterface[0]: Received message from worker:
{"iccType":"sim","iccid":"89441000000400617452","rilMessageType":"iccinfochange","rilMessageClientId":0,"mcc":"001","mnc":"01","ons":"Operateur
Name
String","ons_short_form":"FNAC","isDisplayNetworkNameRequired":true,"isDisplaySpnRequired":true,"msisdn":"11001894790","spn":"Vodafone"}
        Line 7877: 02-09 03:54:44.190   162   630 I Gecko   : RIL Worker: [0]
readingSST:MSISDN:
        Line 7878: 02-09 03:54:44.191   162   630 I Gecko   : RIL Worker: [0]
MSISDN: MSISDN is available
        Line 7878: 02-09 03:54:44.191   162   630 I Gecko   : RIL Worker: [0]
MSISDN: MSISDN is available
        Line 8105: 02-09 03:54:46.044   162   630 I Gecko   : RIL Worker: [0]
MSISDN: 0155663140
        Line 8107: 02-09 03:54:46.048   162   162 I Gecko   : -*-
RadioInterface[0]: Received message from worker:
{"iccType":"sim","iccid":"89441000000400617452","rilMessageType":"iccinfochange","rilMessageClientId":0,"mcc":"001","mnc":"01","ons":"Operateur
Name
String","ons_short_form":"FNAC","isDisplayNetworkNameRequired":true,"isDisplaySpnRequired":true,"msisdn":"0155663140","spn":"Vodafone"}
--------------------log end--------------------------

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Hi Pengfei,

Will Phone number in Settings app be shown correctly after rebooting the phone?

Comment 6

[pengfei.huang]

(In reply to Sean Lee [:seanlee] from comment #5)
> Hi Pengfei,
> 
> Will Phone number in Settings app be shown correctly after rebooting the
> phone?
  Yes, it's correct after rebooting.

Comment 7

[Peipei Cheng (needinfo if you need my action)]

Sean, per comment 6 the phone number in Settings app is correct after reboot.

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Attachment: Trail Patch for v2.0m

Hi Pengfei,

Could you help to test the trail patch? Thank you.

Comment 10

[pengfei.huang]

Attachment: mtklog_SDN_PASS.zip

Hi Sean,
  we see the Phone number changed. Test pass.
  Nice patch. Thank you very much.

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Attachment: Trail Patch for v2.0m

Hi Pengfei,

Could you help to try this patch again?
This one is simpler and removed debug messages.
Thank you.

Comment 12

[pengfei.huang]

Hi Sean,
  Yeah, patch works well. Pass the test.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/Settings/v2.1/Bug1131552 > mozilla-b2g:v2.1

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/Settings/v2.0m/Bug1131552 > mozilla-b2g:v2.0m

Comment 15

[Sean Lee [:seanlee][:weilonge]]

Attachment: PR for v2.0m

Hi Arthur,

Could you help to review this patch for v2.0m?
Thank you.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8563932 [details] [review]
PR for v2.0m

Good job! r=me.

Comment 17

[Sean Lee [:seanlee][:weilonge]]

Arthur, Thank you!

landed on v2.0m : https://github.com/mozilla-b2g/gaia/commit/a1b5959728c8bc2a82354e197bb161922d419866

Comment 18

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8563932 [details] [review]
PR for v2.0m

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):

[User impact] if declined:
Phone Number in Settings/About will not be updated when msisdn or mdn is changed.

[Testing completed]:
1. Partner tested PASS in their LAB.
2. Unit test tested PASS.

[Risk to taking this patch] (and alternatives if risky):
Only changed at Settings app. Very minor risk.

[String changes made]:
None

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/5d3479fdd438412adee4452720856b6b771fe5cd

Are v2.2/v3.0 unaffected?

Comment 20

[Sean Lee [:seanlee][:weilonge]]

Hi Ryan,

Thanks for your concern.

This patch is tested by TCL on v2.0m, and v2.1 has the same architecture. I think there is no much risk to cherry-pick to v2.1.

Settings app has a lot of architecture changes on v2.2/v3.0, so we need to discuss if it's really affected to v2.2/v3.0.

Hi Arthur,

Do you think this issue is affected to v2.2/v3.0?
IMHO, we need to listen event 'iccinfochange' and invoke '_loadHardwareInfo' to update the information.
I think the modification would be in HardwareInfo.prototype.init .
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/about/hardware_info.js#L29

Do you have any suggestions?

Thank you!

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

Yes, the change should be made to the code you mentioned. The only difference would be in v2.2 and 3.0 it is discouraged to use IccHelper as it is planned to be deprecated. Please use SimSlotManager in the shared folder instead.

Comment 22

[sync-1]

Dear Wayne Teng,
   we can close this bug, please see TCL bug907795.
   Thanks.