1131597 - Report link reappears in Reviews page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Load MP-stage homepage  https://marketplace.allizom.org 
2. Open Reviews page for any app (i.e. https://marketplace.allizom.org/app/stay-fit/ratings) 
3. Click “Report” link for any review
4. Leave app page
5. Go back to app Reviews page from where you reported the review at step 3

Expected results:
The “Report” link is not displayed in app Reviews page under the reported comment.

Actual results:
The “Report” link is displayed in app Reviews page. If user tries to re-report the review, the message “Sorry there was an issue flagging the review. Please try again later” appears. The “Report” link is no longer displayed after page refresh. 

Notes/Issues:
Verified on FF38 (Win 7). Issue is also reproducing on FF OS 2.0 (Flame)
Screencast for this issue http://screencast.com/t/GyAqbsDxXBWe

Comment 1

[Chuck Harmston [:chuck]]

The presence of the regression keyword implies that this did not happen before the desktop ui refresh. Can you confirm that, Valentina? I cannot find any code that would support that.

Comment 2

[Valentina Virlics [:vvalentina], Ecosystem QA]

I did not find a screencast with the report section, before desktop UI refresh...sow is hard to demonstrate that this is a regression. I just recall not seeing that (comment #0) before. You may delete the regression keyword if you think is not proper to be there.

Comment 3

[Chuck Harmston [:chuck]]

If it's not a regression, it probably doesn't belong on this tracker and is likely lower priority than a P3. ni?ddurst for re-triage.

Comment 4

[David Durst [:ddurst]]

I'm unclear on when this regression would have happened. ValentinaP, was this working previously (say, a few weeks ago) and recently changed? Or was this just recently noticed?

Comment 5

[Kevin Ngo [:ngoke]]

I don't think this is a regression, but it is a valid bug.

Currently, we have an odd behavior where ALL anonymous users can only report a given review once, since we do a user=XXX filter for has_flagged. If one anon user flags a review, and another anon user tries to flag it, a "You have already flagged this review" error will arise, which is weird since they're anon.

And it's impossible to keep track of which anon user already flagged a review. And it'd weird to restrict non-anonymous users that developers can't flag and users can only flag a review once, and to not restrict anonymous users.

So talking to Krupa, we decided to only allow logged-in users to flag reviews, and prompt anon users to log in to flag.

Comment 6

[Mathieu Pillard [:mat]]

Are we sure we want to disallow anonymous flagging ? It is fairly common to let visitors report comments on websites, without forcing them to have an account to do that. I'm concerned that we'd miss useful feedback about abusive/hateful/illegal content if we do this.

For the record, I had noticed this particular bug back when converting the API from Tastypie to DRF and decided to let the behaviour because of this concern. IMHO we could make the message let confusing and simply say "This review has already been flagged" for anonymous users.

Comment 7

[Kevin Ngo [:ngoke]]

Hm, I didn't realize that it is probably okay to allow for all anonymous users to flag a review just once. Although my last hour, I may go with just raising a notification.

Comment 8

[Kevin Ngo [:ngoke]]

last hour will have been wasted*

Comment 9

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to David Durst [:ddurst] from comment #4)
> I'm unclear on when this regression would have happened. ValentinaP, was
> this working previously (say, a few weeks ago) and recently changed? Or was
> this just recently noticed?

Related to Report, i recall seeing the link disappear for non-anonymous users.

Comment 10

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/1032 for original STR.

Will also hide Report link to an anonymous user if an anonymous user has already flagged it.

Comment 11

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Kevin Ngo [:ngoke] from comment #10)
> https://github.com/mozilla/fireplace/pull/1032 for original STR.
> 
> Will also hide Report link to an anonymous user if an anonymous user has
> already flagged it.

Verified as fixed on FF38(Win 7).
Postfix screencast http://screencast.com/t/qYFEoanaJYyJ
Closing bug.

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1135570

Comment 12

[Valentina Virlics [:vvalentina], Ecosystem QA]

I've found the same issue, but following different STR (this issue seems to be related to clicking the "Load More" button from Reviews page):
1. Load MP-dev homepage  https://marketplace-dev.allizom.org 
2. Open Reviews page for any app (i.e. https://marketplace-dev.allizom.org/app/loqui/ratings)
3*. Click "Load more" blue button 
3. Click “Report” link for any review that was displayed after step 3*.
4. Leave app page
5. Go back to app Reviews page from where you reported the review at step 3.

Please see the screencast: http://screencast.com/t/tHaPrQJfQ1

Comment 13

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/commit/5d710c4e34b64cdbb27b4c35c50c0d5ad4343753

Comment 14

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on FF39(Win 7).
Postfix screencast http://screencast.com/t/lXzrggWcPB
Closing bug.