1131631 - [Dialer] bdi tag remains in conference call participants screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Tamara Hills [:thills]]

STR:

1. Create a conference call
2.  Go to the conference participants list
Expected:  Should see the string "conference (2)" 
Actual:  See the string "<bdi> conference (2) </bdi"

I believe this was introduced by bug 1126850.

Comment 1

[bhavana bajaj [:bajaj]]

fallout from https://bugzilla.mozilla.org/show_bug.cgi?id=1126850

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] tamarahills:bugfix/1131631-fix-confgroup-ui-header-rtl > mozilla-b2g:master

Comment 3

[Tamara Hills [:thills]]

Attachment: PR for a fix

Comment 4

[Tamara Hills [:thills]]

Comment on attachment 8566715 [details] [review]
PR for a fix

Redirecting to drs.

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8566715 [details] [review]
PR for a fix

Looks good, but I left one nit on the PR. Please fix that before landing. This will also retrigger the tests, which don't seem to have run.

Comment 6

[Tamara Hills [:thills]]

https://github.com/mozilla-b2g/gaia/commit/a21a75c8b9666f6f71b4f247d8a9258e725e65e0
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=412b044c039c

NI to myself to ask for uplift.

Comment 7

[Tamara Hills [:thills]]

Comment on attachment 8566715 [details] [review]
PR for a fix

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Regression caused by 1126850
[User impact] if declined: User would see <bdi>Conference(2)</bdi> on the conf call participants page.  BDI tags should not be visible.  It will be a bad ux.
[Testing completed]:yes
[Risk to taking this patch] (and alternatives if risky):low
[String changes made]:no

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Reassigning to Bhavana ([e-mail] is now about Firefox Desktop)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/aa4a0645d503df7fb8679cabe1d35b7c4bc998c9

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual results:  The bdi tag is not shown on the cal participant screen.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150227010229
Gaia: 7512026a377271a0cade12d70846557f0bc7781c
Gecko: c7968255c1ea
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150227002521
Gaia: eb6a5ac9081d3962198e0f4520b0743d716d7a27
Gecko: c8a38dcfbebc
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0