1131666 - [FTE] Update Carets

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Eric Pang [:epang] UX]

Attachment: FTE.jpg

The carets need to be updated in the navigation buttons of the FTE.  See attached image.

Comment 1

[Sam Foster [:sfoster] (he/him)]

What do they need to be updated to?

Comment 2

[Eric Pang [:epang] UX]

(In reply to Sam Foster [:sfoster] from comment #1)
> What do they need to be updated to?

Hey Sam, there's more info in the Meta bug.  But we want to use the new caret svg that's also attached in the meta (it's smaller and semi transparent)

See this image:
https://bug1131641.bugzilla.mozilla.org/attachment.cgi?id=8562143

One thing I don't know tho is how the button works - is the caret an overlay?  Or is it added on top of the button with code?

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] pivanov:bug-1131666 > mozilla-b2g:master

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

This one will be fixed in Bug 1131666

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

wrong bug pls ignore comment 5

Comment 7

[Eric Pang [:epang] UX]

Comment on attachment 8563569 [details] [review]
patch for Gaia/master

Looks good R+, Thanks!

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8563569 [details] [review]
patch for Gaia/master

changing reviewer to Fernando, as he is FTE owner

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/9ae9b1410296db55d25e50c3afa63720ff691256

Comment 10

[James Burke [:jrburke]]

Comment on attachment 8563569 [details] [review]
patch for Gaia/master

[Approval Request Comment]
Bug 1118893 is 2.2+ and this changeset provides the shared image used for that bug fix. All the bugs off of the meta bug 1131641 for new carats should land on 2.2. 

[Bug caused by] (feature/regressing bug #):
Change desired for RTL to have indicators that there are sub-screens, but without the bigger thicker carats used before, tracked in meta bug 1131641.

[User impact] if declined:
The desired look of these carats will not be part of the RTL effort.

[Testing completed]:
Just CSS/image changes, received ui-review+.

[Risk to taking this patch] (and alternatives if risky):
Very low, just a CSS/image change.

[String changes made]:
None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e457433cf13c6a5304565665ecf49ecff6047fd3

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual results:  There FTE uses the newer smaller carat size.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150227010229
Gaia: 7512026a377271a0cade12d70846557f0bc7781c
Gecko: c7968255c1ea
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150227002521
Gaia: eb6a5ac9081d3962198e0f4520b0743d716d7a27
Gecko: c8a38dcfbebc
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0