Closed Bug 1131641 Opened 5 years ago Closed 5 years ago

[META] Update caret styling OS wide for both RTL and LTR

Categories

(Firefox OS Graveyard :: Gaia::Shared, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.2+)

RESOLVED FIXED
feature-b2g 2.2+

People

(Reporter: epang, Assigned: pivanov)

References

Details

Attachments

(2 files, 1 obsolete file)

Hi Pavel,

This is a meta bug to update the carets (arrows) across the OS.  Do you have time to help out with this?  

I've created a new svg that should replace 
https://github.com/gaia-components/gaia-icons/blob/master/images/forward-light.svg

I'll be opening bugs for different apps with this meta collecting them all.  The problem is that not all apps use the shared asset.  Is it possible to update them to use the shared asset?  If not, please let me know if something else needs to be provided asset wise.

The updated caret should have the same margins as the current one.  I'll point out where it needs to be changed per app in each bug.
Attached image forward-light.svg
Updated carat specs:

Height 1.3 rem on HVGA 
Colour: #667174
Opacity: 70%
Margins: Same as current
Attached image Udpated Carets visuals.jpg (obsolete) —
The areas we need to update the carets in each app.
The areas we need to update the carets in each app.
Attachment #8562136 - Attachment is obsolete: true
Depends on: 1131665
Depends on: 1131666
Depends on: 1131668
Depends on: 1131675
Depends on: 1131678
Depends on: 1131679
Just my two cents: in RTL mode, having a “left” arrow for the header “back” button and a (smaller) “right” carat for menu items **in the same column** can be confusing. Would that be possible to use a more generic “back” icon and/or a more generic “click me” icon, rather than arrows?
feature-b2g: --- → 2.2?
Kaze, I agree with you, but as discussed in triage... ;) This is what we were able to get agreement on for now. We certainly hope to have a better solution post 2.2, ideally changing the arrow direction completely!
Depends on: 1132732
Josh, can you help to triage this bug? 
Thanks.
Flags: needinfo?(jocheng)
Hi Stephany,
I nominate this to 3.0? per your comment 5.
Please let me know if you have any question. Thanks!
feature-b2g: 2.2? → 3.0?
Flags: needinfo?(jocheng) → needinfo?(swilkes)
Sorry. This visual change is key to the fact that we're not changing back button direction and is a 2.2 blocker.
feature-b2g: 3.0? → 2.2+
Flags: needinfo?(swilkes)
[:josh] from comment #7)
> Hi Stephany,
> I nominate this to 3.0? per your comment 5.
> Please let me know if you have any question. Thanks!

This bug is for the 2.2 work and I think can be resolved as all of the dependencies are already closed out. Any future changes for 3.0 or another release will be done in a separate bug.(In reply to Josh Cheng
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.