1131793 - Black video on Lenovo S650

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

From comments in bug 1100126, this specific device is having some trouble.

Comment 1

[florin arjocu]

This is Lenovo factory Android 4.2.2 and any other media player or browser (mxplayer, Google Chrome, default Android browser) work fine with html5 movies. As I could read in the previous bug report, it uses a mediatek chip (I have no idea how to see this). If you need any info / debug, I can help you with that.

There must be many other devices having the problem, but they haven't reported or seen it in action.

Comment 2

[florin arjocu]

PS: Mp3 do not play either on Mozilla media page one of you guys provided (but aac does play).

Comment 3

[Aaron Train [:aaronmt]]

(In reply to florin arjocu from comment #2)
> PS: Mp3 do not play either on Mozilla media page one of you guys provided
> (but aac does play).

We're aware of the MP3 problem: https://bugzilla.mozilla.org/show_bug.cgi?id=1093815

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Bug 1093815 is really for Lollipop devices where we're unable to use the OMX plugin. It *should* work on 4.2.2, but results can vary between device vendors -- which is why we want to nuke that everywhere.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

I have a Lenovo S650 coming to me this week. I'll see what's going on here.

Comment 6

[florin arjocu]

@James Willcox - I am stubborn on this: can't the solution be found in other piece of software which works?

Ultil you get the Lenovo s650 phone, can I help you somehow with some debugging stuff?

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to florin arjocu from comment #6)
> @James Willcox - I am stubborn on this: can't the solution be found in other
> piece of software which works?
> 
> Ultil you get the Lenovo s650 phone, can I help you somehow with some
> debugging stuff?

We are more or less doing the same thing as other applications now. There are some differences, however, due to the additional features the web has compared to a standalone player as well as Gecko's architecture.

Have I asked you to get a logcat yet? I don't see it on the other bug. If you are able to do that it could help.

Comment 8

[florin arjocu]

@James Wilcox - no, you haven't asked that. But be more precise, I have no idea how to do that :)

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to florin arjocu from comment #8)
> @James Wilcox - no, you haven't asked that. But be more precise, I have no
> idea how to do that :)

It's a little involved -- you need to install the Android SDK tools, etc. Once you do that, you can do something like this: https://wiki.mozilla.org/Mobile/Fennec/Android#Using_logcat

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

I have the Lenovo S650 now, and can reproduce the problem. Logs have:

I/SurfaceTexture( 3723): [unnamed-3723-1](this:0x73f3f548,api:3) attachToContext
E/SurfaceTexture( 3723): [unnamed-3723-1](this:0x73f3f548,api:3) error creating EGLImage: 0x3003

and then later on

E/SurfaceTexture( 3723): [unnamed-3723-1](this:0x73f3f548,api:3) updateTexImage: SurfaceTexture is not attached to an OpenGL ES context
I/SurfaceTexture( 3723): [unnamed-3723-1](this:0x73f3f548,api:3) detachFromContext
E/SurfaceTexture( 3723): [unnamed-3723-1](this:0x73f3f548,api:3) detachFromContext: SurfaceTexture is not attached to a context

So I would say that the attach/detach API for SurfaceTexture is just busted on this phone.

Comment 12

[florin arjocu]

I can hardly wait to not be forced to use Chrome for this (+mp3's player). For now it seems to be one of the very few things Firefox needs to become the very best browser for android.

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Disable SurfaceTexture detach on Mali

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to florin arjocu from comment #12)
> I can hardly wait to not be forced to use Chrome for this (+mp3's player).
> For now it seems to be one of the very few things Firefox needs to become
> the very best browser for android.

If MP3 isn't working for you now, it might be a while. See bug 1093815.

Comment 15

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/509c07949a4c

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/509c07949a4c

Comment 17

[James Willcox (:snorp) ([e-mail]) (he/him)]

Florin, have you tried the latest Nightly? The bug should be fixed there.

Comment 18

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8564395 [details] [diff] [review]
Disable SurfaceTexture detach on Mali

Approval Request Comment
[Feature/regressing bug #]: 1097116
[User impact if declined]: Black video on some devices using Mali GPU
[Describe test coverage new/current, TreeHerder]: nightly
[Risks and why]: low, exercises common fallback path
[String/UUID change made/needed]: none

Comment 19

[florin arjocu]

@James Willcox - yes, from the 2-3 clips I have tested, it seems to be fixed. Thank you.

Comment 20

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8564395 [details] [diff] [review]
Disable SurfaceTexture detach on Mali

Patch is small and shown to be good. From bug 1097116 it looks like 36 is affected. Are we seeing this in significant enough volume to warrant a late uplift to Beta?

Aurora+

Comment 21

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #20)
> Comment on attachment 8564395 [details] [diff] [review]
> Disable SurfaceTexture detach on Mali
> 
> Patch is small and shown to be good. From bug 1097116 it looks like 36 is
> affected. Are we seeing this in significant enough volume to warrant a late
> uplift to Beta?

It would be good to get it there, but I decided not to uplift some other dependent patches because of the churn involved. (Bug 1100126).

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/02451c7d1558

Comment 23

[florin arjocu]

I do not know if this should be here, but trying to watch this movie in html5 (with nightly) - http://superweb.rol.ro/video/be47216ecd77d1a007f15c5cee66dc81.html -  cannot be done, the image stops after a short while and only the sound continues. I guess something happens, but cannot tell what.