1) Only store the registration after activation has finished (state Activate, not Activating) 2) Restored state should be set to Activated.
/r/3719 - Bug 1131874 - ServiceWorker persistence activation fixes. /r/3721 - Bug 1131874 - dummy commit to deal with mozreview IGNORE IT Pull down these commits: hg pull review -r b326b05a63dcd8f60c3d44cfb466b5bb58f961af
Attachment #8562471 - Flags: review?(amarchesini)
nsm, it seems that the mozreview team is not going to implement persona login soon. Can you please send me "old-style" review requests? About this patch: SetStateUncheckedAndWithoutEvent is just used to activate the worker. So probably we can just change it to: SetActivateStateUnckedWithoutEvent(). Or are you planning to use this method in other contexts? r=me
Attachment #8562471 - Flags: review?(amarchesini) → review+
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Attachment #8562471 - Attachment is obsolete: true
Attachment #8562871 - Flags: review+
Added r=baku to commit message.
Attachment #8562871 - Attachment is obsolete: true
Please provide a Try link.
You need to log in before you can comment on or make changes to this bug.