1131874 - ServiceWorker persistence activation fixes

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

1) Only store the registration after activation has finished (state Activate, not Activating)
2) Restored state should be set to Activated.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: bz://1131874/nsm

/r/3719 - Bug 1131874 - ServiceWorker persistence activation fixes.
/r/3721 - Bug 1131874 - dummy commit to deal with mozreview IGNORE IT

Pull down these commits:

hg pull review -r b326b05a63dcd8f60c3d44cfb466b5bb58f961af

Comment 2

[Andrea Marchesini [:baku]]

nsm, it seems that the mozreview team is not going to implement persona login soon.
Can you please send me "old-style" review requests?

About this patch:

SetStateUncheckedAndWithoutEvent is just used to activate the worker. So probably we can just change it to: SetActivateStateUnckedWithoutEvent(). Or are you planning to use this method in other contexts?

r=me

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: ServiceWorker persistence activation fixes

Renamed

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: ServiceWorker persistence activation fixes

Added r=baku to commit message.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please provide a Try link.

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/afad28f235a8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afad28f235a8