Closed
Bug 1131874
Opened 8 years ago
Closed 8 years ago
ServiceWorker persistence activation fixes
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file, 2 obsolete files)
3.51 KB,
patch
|
Details | Diff | Splinter Review |
1) Only store the registration after activation has finished (state Activate, not Activating) 2) Restored state should be set to Activated.
Assignee | ||
Updated•8 years ago
|
Blocks: ServiceWorkers-v1
Assignee | ||
Comment 1•8 years ago
|
||
/r/3719 - Bug 1131874 - ServiceWorker persistence activation fixes. /r/3721 - Bug 1131874 - dummy commit to deal with mozreview IGNORE IT Pull down these commits: hg pull review -r b326b05a63dcd8f60c3d44cfb466b5bb58f961af
Attachment #8562471 -
Flags: review?(amarchesini)
Comment 2•8 years ago
|
||
nsm, it seems that the mozreview team is not going to implement persona login soon. Can you please send me "old-style" review requests? About this patch: SetStateUncheckedAndWithoutEvent is just used to activate the worker. So probably we can just change it to: SetActivateStateUnckedWithoutEvent(). Or are you planning to use this method in other contexts? r=me
Updated•8 years ago
|
Attachment #8562471 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Renamed
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Attachment #8562471 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8562871 -
Flags: review+
Assignee | ||
Comment 4•8 years ago
|
||
Added r=baku to commit message.
Assignee | ||
Updated•8 years ago
|
Attachment #8562871 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/afad28f235a8
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/afad28f235a8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•