ServiceWorker persistence activation fixes

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nsm, Assigned: nsm)

Tracking

33 Branch
mozilla39
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

1) Only store the registration after activation has finished (state Activate, not Activating)
2) Restored state should be set to Activated.
Created attachment 8562471 [details]
MozReview Request: bz://1131874/nsm

/r/3719 - Bug 1131874 - ServiceWorker persistence activation fixes.
/r/3721 - Bug 1131874 - dummy commit to deal with mozreview IGNORE IT

Pull down these commits:

hg pull review -r b326b05a63dcd8f60c3d44cfb466b5bb58f961af
Attachment #8562471 - Flags: review?(amarchesini)
nsm, it seems that the mozreview team is not going to implement persona login soon.
Can you please send me "old-style" review requests?

About this patch:

SetStateUncheckedAndWithoutEvent is just used to activate the worker. So probably we can just change it to: SetActivateStateUnckedWithoutEvent(). Or are you planning to use this method in other contexts?

r=me
Attachment #8562471 - Flags: review?(amarchesini) → review+
Created attachment 8562871 [details] [diff] [review]
ServiceWorker persistence activation fixes

Renamed
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Created attachment 8562872 [details] [diff] [review]
ServiceWorker persistence activation fixes

Added r=baku to commit message.
Keywords: checkin-needed
Please provide a Try link.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/afad28f235a8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.