1131878 - Look in to re-enabling e10s in the harness

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Bug 1047603 is in some stage of landing and should fix the window.open() issues that motivated shutting off e10s.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

With bug 1047603 landed now, can e10s be re-enabled in the harness?

Comment 2

[Chris Manchester (limited bugmail, email directly)]

The other concern was not being able to handle remoteness changes (navigation to/from non-remote about: pages). I'm working on that this week, :whimboo should we block on that as well?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, we need about:error pages a lot in the security tests, which are now our P1.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: PR fixing stuff

Everything passes with e10s now. We can leave it off if it's problematic for in-progress test conversion, but might as well get this in.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8576321 [details] [review]
PR fixing stuff

Lovely. What about generally enabling e10s? Are we still blocked on something else? I can remember problems with window.open(). Are those still present?

Comment 6

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Comment on attachment 8576321 [details] [review]
> PR fixing stuff
> 
> Lovely. What about generally enabling e10s? Are we still blocked on
> something else? I can remember problems with window.open(). Are those still
> present?

Nothing I know of, all our tests pass with e10s on locally. Like I said we can leave it off for a little while if we're worried about disturbing in-progress test work, but let's see if that's an issue.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

I merged the PR here: https://github.com/mozilla/firefox-ui-tests/commit/0bf41b07cc43ff8e9657dddc966e236aff308db4

I'll leave the bug open until we actually turn it on.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What about the --e10s option? This would work at the moment already?

Comment 9

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) from comment #8)
> What about the --e10s option? This would work at the moment already?

Yep!

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Bug 1162408 gets these running in parallel to non-e10s in our Travis tests with a small number still disabled.