1131994 - mochitest failures on various CSS logical properties when vertical writing-mode is enabled

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Kew [:jfkthame]]

When layout.css.vertical-text.enabled is set to true, so that the CSS writing-mode property and the new logical box properties (for margins, borders, etc) are enabled, we get a bunch of mochitest failures related to the new properties.

A few samples:
 1106 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_exposed_prop_accessors.html | border-block-end should now be set - didn't expect , but got it 
 1618 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_inherit_computation.html | should be testing with values that compute to different things for 'block-size' - didn't expect height, but got it 
 2231 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_initial_computation.html | should be testing with values that compute to different things for 'inline-size' - didn't expect width, but got it 
 2722 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value 'none' not accepted for 'max-block-size' property - got none, expected 
 6006 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_value_cloning.html | serialization should be nonempty for border-block-start: 5px green none - didn't expect , but got it 
 18910 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_value_computation.html | should be testing with values that compute to different things for 'block-size' - didn't expect height, but got it 
 22727 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_value_storage.html | setting 'none' on 'border-block-end' - didn't expect , but got it 

See https://treeherder.mozilla.org/#/jobs?repo=try&revision=69d2545dfb1e

Comment 1

[Cameron McCormack (:heycam)]

With fixes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb30572a952d

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Part 1: Support border-block-{start,end} shorthands in Declaration::GetValue.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 2: Fix logical axis and offset property computed value lookup in tests.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Part 3: Fix bad invalid_values in property_database.js for max-{block,inline}-size.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: Part 4: Don't fail test_value_computation.html on min-{block,inline}-size:calc(-1%).

Comment 6

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6010300a59
https://hg.mozilla.org/integration/mozilla-inbound/rev/2af5e7c23456
https://hg.mozilla.org/integration/mozilla-inbound/rev/17ed7ce69a13
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb9b8ab059d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f6010300a59
https://hg.mozilla.org/mozilla-central/rev/2af5e7c23456
https://hg.mozilla.org/mozilla-central/rev/17ed7ce69a13
https://hg.mozilla.org/mozilla-central/rev/fcb9b8ab059d