Closed
Bug 1132141
Opened 8 years ago
Closed 8 years ago
Update storage when ServiceWorker registration fails.
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
3.90 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
If register() fails, remove the registration we've persisted.
Assignee | ||
Updated•8 years ago
|
Blocks: ServiceWorkers-v1
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8562929 -
Flags: review?(amarchesini)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Comment on attachment 8562929 [details] [diff] [review] Update storage when ServiceWorker registration fails Review of attachment 8562929 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/ServiceWorkerManager.cpp @@ +2416,5 @@ > +{ > + MOZ_ASSERT(aRegistration); > + MOZ_ASSERT(!aRegistration->IsControllingDocuments()); > + MOZ_ASSERT(mServiceWorkerRegistrationInfos.Contains(aRegistration->mScope)); > + ServiceWorkerManager::RemoveScope(mOrderedScopes, aRegistration->mScope); you don't need ServiceWorkerManager:: right? @@ +2436,5 @@ > + PrincipalInfo principalInfo; > + if (NS_WARN_IF(NS_FAILED(PrincipalToPrincipalInfo(reg->mPrincipal, > + &principalInfo)))) { > + //XXXnsm I can't think of any other reason a stored principal would fail to > + //convert. then just do: NS_ALWAYS_TRUE(NS_SUCCEEDED(PrincipalToPrincipalInfo(...
Attachment #8562929 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ebbc5550931
Comment 4•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ebbc5550931
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•