TSan: data race netwerk/cache2/CacheEntry.cpp:1626 StoreFrecency

RESOLVED FIXED in Firefox 39

Status

()

Core
Networking: Cache
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: froydnj, Assigned: mayhemer)

Tracking

(Blocks: 1 bug)

unspecified
mozilla39
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [tsan])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8562979 [details]
netwerk-cache-race.txt

[cribbing from decoder's script, hopefully he won't mind]

The attached logfile shows a thread/data race detected by TSan (ThreadSanitizer).

Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1].

If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist.

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
(Assignee)

Updated

3 years ago
Assignee: nobody → honzab.moz
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8583371 [details] [diff] [review]
v1

Simply post the new frecency value as an argument.  Done.
Attachment #8583371 - Flags: review?(michal.novotny)
Attachment #8583371 - Flags: review?(michal.novotny) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9369346e7e4a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.