1132186 - [RTL][Contacts] - The icons overlap the text for the import / export contacts buttons on the contacts settings page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Joshua Mitchell (Inactive)]

Attachment: 2015-02-11-12-33-40.png

Description:
On the contacts settings page there are two 'transfer contacts' buttons; one for import and one for export. Each button has an icon on it of a torso and direction arrow. In RTL, these icons overlap the button text

Repro Steps:
1) Update a Flame to 20150211010216 and set language to an RTL language (Arabic)
2) Open contacts
3) Select Settings

Actual:
icons overlap the import / export button text

Expected:
icons will be most right aligned and the text will be spaced next to it

Environmental Variables:
Device: Flame 3.0
Build ID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Repro frequency: 4/4
See attached: screenshot

---------------------------------------------------------------------------------

Issue does NOT reproduce in 2.1

Actual results - icons do not overlap 

Device: Flame 2.2 (KK - Nightly - Full Flash)
Build ID: 20150211002505
Gaia: 943be6fd146017dcd9d4c9d1027be1e43bad13eb
Gecko: e614443583e7
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:

Identifiable regression of a supported feature.

Requesting a window.

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1130231 seems to have caused this issue.

Mozilla-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150209063429
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: c13e7799a147
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150209064732
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 70a1847bdc20
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working gaia / First Broken gecko - Issue DOES occur
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 70a1847bdc20

First Broken gaia / Last Working gecko - Issue does NOT occur
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: c13e7799a147

Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c13e7799a147&tochange=70a1847bdc20

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Jonathan, can you take a look at this please? Looks like bug 1130231 might have caused this to occur. Can we get this backed out on Master?

Comment 4

[Jonathan Kew [:jfkthame]]

I suspect this is a Gaia CSS issue, similar to bug 1132194 and bug 1131827; the fix in bug 1130231 is exposing cases where Gaia's CSS is not correct for RTL, but happened to work with the previous (buggy) behavior of button padding.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

Comment 6

[Jonathan Kew [:jfkthame]]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

Here's another example of direction-specific padding within a button, exposed by fixing bug 1130231.

Comment 7

[Dylan Oliver [:doliver]]

triage: not marking for feature-b2g:2.2 at this time because it's marked as unaffected, but if this does show up on 2.2, please request approval for uplift.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Dylan, we need to add feature-b2g:2.2, since 2.2 will be affected once bug 1130231 lands.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

Thanks!

Comment 10

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

Ah duh, I'm not a system peer. Kevin, could you stamp this?

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

This seems to be a contacts patch, which I'm not a peer of. Forwarding the request to Francisco.

Comment 13

[Johan Lorenzo [:jlorenzo]]

Clearing the blocking 3.0 nom as already tracked under the feature flag.

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

Francisco is a bit swamped this week. Jose, can you take a look?

Comment 15

[Jose Manuel Cantera]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

LGTM

thanks

Comment 16

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f698d41230bf7b94a9d16692c36251f816c519bc

Comment 17

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8563575 [details] [review]
[gaia] jfkthame:jfkthame-patch-1 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bug 1130231 

[User impact] if declined:
Broken UI for RTL on contacts import/export form.

[Testing completed]:
Manually tested.

[Risk to taking this patch] (and alternatives if risky):
Low risk as it's a css only change. No alternative if we want this fixed for RTL.

[String changes made]: none.

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is veried fixed on the latest Nightly Flame 3.0 build.  Adding verifyme tag so this can get checked once the 2.2 uplift occurs.
	
Actual Results: The icons and text do not overlap.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f09025315aef796f9b9fa70a1997dc858bbe5d31

Comment 20

[SandKing]

Attachment: Verified picture: 2015-02-27-11-29-03.png

This issue has been verified successfully on latest Flame2.2
Verify picture:"2015-02-27-11-29-03.png"
Occur Rate: 0/10

Flame 2.2 build:
Build ID               20150226162510
Gaia Revision          eb6a5ac9081d3962198e0f4520b0743d716d7a27
Gaia Date              2015-02-26 17:25:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1be266320634
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150226.195624
Firmware Date          Thu Feb 26 19:56:35 EST 2015
Bootloader             L1TC000118D0