1132219 - Gaia tests for a bad function name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Tom S]

In bug 1073816 we want to change the function name of bound function to something like "bound " + original function name. However Gaia seems to have some tests that think that f.name == f.bind().name should be true. https://treeherder.mozilla.org/logviewer.html#?job_id=6418506&repo=mozilla-inbound We will need to be clever about fixing this, because if we patch Gaia before SpiderMonkey the tests fail, but the reverse is also true.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd suggest simultaneously landing the gaia changes to gaia and the gecko changes to b2g-inbound so they land really close to each other. There might be a few pushes where either the gaia changes or the gecko changes are present without the other, but as long as you ping a sheriff before you do the landings, neither should be backed out before they have the chance to sync up with the other.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Yep, sounds exactly right to me - push the Gecko change to b-i, then immediately push the Gaia change (or merge the PR). There may be a job or two that burns, but the bustage should be minimized that way.

Comment 3

[Alberto Pastor [:albertopq]]

Hey Tom, is anybody working in the gaia patch you were mentioning in #c1?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Taking

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1132219-fix-gu22-gu29 > mozilla-b2g:master

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/adbbbcddcf6698aa2eb47b1c2f1c3f053fe999da