Closed Bug 1132630 Opened 5 years ago Closed 4 years ago

ES6 bound function name

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(2 files)

I didn't enable the bound function name change in bug 1073816, because it breaks Gaia tests.
No longer blocks: es6
Duplicate of this bug: 1097976
Assignee: nobody → evilpies
I pushed this to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3622f10ea82b. Without b2g there are probably not going to be any weird tests.
Attachment #8716627 - Flags: review?(till)
Comment on attachment 8716626 [details] [diff] [review]
Renumber steps in Function.prototype.bind

Review of attachment 8716626 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: js/src/builtin/Function.js
@@ +2,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +// 19.2.3.2 Function.prototype.bind
> +// https://github.com/tc39/ecma262/commit/c2d1363b94cda3fd9015e73e3938189e64acb59f

Hmm, it's unfortunate that we can't add link to rendered versions of specific drafts. Give that, I think I'd prefer "ES7 draft January 21, 2016". The link doesn't get you any closer to actually reading the right version of the spec, and is less clear.
Attachment #8716626 - Flags: review?(till) → review+
Comment on attachment 8716627 [details] [diff] [review]
Prefix bound function names

Review of attachment 8716627 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8716627 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/1d13b1102685
https://hg.mozilla.org/mozilla-central/rev/3e636d1a0102
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.