1132452 - Remove deprecated addon files in Firefox OS Simulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Jan Keromnes [:janx]]

Once WebIDE is in charge of tracking installed Simulators[1], Simulators won't need to register themselves anymore, so we can clean up a bunch of files in b2g/simulator/.

Upstreaming this cleanup to older simulators will then allow us to remove toolkit/devtools/apps/Simulator.jsm in a follow-up patch.

[1] When the patch "Give WebIDE full control over simulator addons" in bug 1090949 has made its way to the majority of WebIDE installs (i.e. landed in m-c and rolled at least to DevEdition)

Comment 1

[Jan Keromnes [:janx]]

Attachment: Remove deprecated addon files in Firefox OS Simulator.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Rebased and also removes options panel.

As said in bug 1210382, this is a good time to proceed with this cleanup.
bug 1090949 in Fx40, release version is now 41, so we should be able to expect
everyone to have this change and no longer needs this compatibility layer.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8669579 [details] [diff] [review]
patch v1

Review of attachment 8669579 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/simulator/bootstrap.js
@@ +1,1 @@
> +function startup(data, reason) {}

I guess you are leaving this because it's needed for the add-on to load?

Should we instead use the "base" bootstrap content that JPM packages[1] with add-ons?  Or is this better since we really don't need anything?

[1]: https://github.com/mozilla-jetpack/jpm-core/blob/master/data/bootstrap.js

::: b2g/simulator/build_xpi.py
@@ +137,3 @@
>          add_file_to_zip(zip, manifest, "install.rdf")
>          add_file_to_zip(zip, os.path.join(srcdir, "bootstrap.js"), "bootstrap.js")
>          add_file_to_zip(zip, options_file, "options.xul")

Seems like this line, and the part that processes the *.in into this file, should be removed.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> Comment on attachment 8669579 [details] [diff] [review]
> patch v1
> 
> Review of attachment 8669579 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/simulator/bootstrap.js
> @@ +1,1 @@
> > +function startup(data, reason) {}
> 
> I guess you are leaving this because it's needed for the add-on to load?
> 
> Should we instead use the "base" bootstrap content that JPM packages[1] with
> add-ons?  Or is this better since we really don't need anything?

There is no need of the base bootstrap, there is nothing to do in bootstrap, really.
We just need these empty method to prevent some warnings in the browser console.
(I also added install/uninstall to prevent other warnings)

> 
> ::: b2g/simulator/build_xpi.py
> @@ +137,3 @@
> >          add_file_to_zip(zip, manifest, "install.rdf")
> >          add_file_to_zip(zip, os.path.join(srcdir, "bootstrap.js"), "bootstrap.js")
> >          add_file_to_zip(zip, options_file, "options.xul")
> 
> Seems like this line, and the part that processes the *.in into this file,
> should be removed.

Oops, I forgot about that.

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6a2f279e344

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/797f58646eb6e4c3ae0591c3ced01cd18cf37138
Bug 1132452 - Remove useless JS files from FxOS simulator addon. r=jryans

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/797f58646eb6

Comment 8

[Alexandre Poirot [:ochameau]]

I don't know how I managed to do that. The changes I made to bootstrap.js are not there.
I see them in the very last try push, and on the last attached patch, but not in the fx-team changeset !!?!?

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: missing bits

Comment 10

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/91150ad92c3313fc26ed7f9a7caf8af2969d879c
Bug 1132452 - Remove useless JS files from FxOS simulator addon. r=jryans

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91150ad92c33