Remove deprecated Simulator.jsm file.

NEW
Assigned to

Status

Firefox OS
Simulator
3 years ago
3 years ago

People

(Reporter: janx, Assigned: janx)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Once simulators don't register themselves anymore (bug 1132452) they'll stop importing toolkit/devtools/apps/Simulator.jsm. At that point, we can remove this deprecated file without causing too many (though harmless) errors to be logged by the simulators.
(Assignee)

Comment 1

3 years ago
Created attachment 8563394 [details] [diff] [review]
Remove deprecated Simulator.jsm file.
(Assignee)

Comment 2

3 years ago
Created attachment 8595434 [details] [diff] [review]
Add a deprecation comment to Simulator.jsm.

Alex, since this bug is relatively long-lived, what do you think of adding a comment to Simulator.jsm, stating that it's deprecated?
Attachment #8595434 - Flags: review?(poirot.alex)
Comment on attachment 8595434 [details] [diff] [review]
Add a deprecation comment to Simulator.jsm.

Review of attachment 8595434 [details] [diff] [review]:
-----------------------------------------------------------------

Good idea!
Attachment #8595434 - Flags: review?(poirot.alex) → review+
(Assignee)

Comment 4

3 years ago
Thanks Alex! Sheriffs, please only land the "deprecation comment" patch. No try, it's just a comment.
Keywords: checkin-needed, leave-open
(Assignee)

Updated

3 years ago
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.