Closed
Bug 1132453
Opened 10 years ago
Closed 7 years ago
Remove deprecated Simulator.jsm file.
Categories
(Firefox OS Graveyard :: Simulator, defect)
Firefox OS Graveyard
Simulator
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: janx, Assigned: janx)
References
Details
Attachments
(2 files)
|
1.74 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.21 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Once simulators don't register themselves anymore (bug 1132452) they'll stop importing toolkit/devtools/apps/Simulator.jsm. At that point, we can remove this deprecated file without causing too many (though harmless) errors to be logged by the simulators.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Alex, since this bug is relatively long-lived, what do you think of adding a comment to Simulator.jsm, stating that it's deprecated?
Attachment #8595434 -
Flags: review?(poirot.alex)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8595434 [details] [diff] [review]
Add a deprecation comment to Simulator.jsm.
Review of attachment 8595434 [details] [diff] [review]:
-----------------------------------------------------------------
Good idea!
Attachment #8595434 -
Flags: review?(poirot.alex) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks Alex! Sheriffs, please only land the "deprecation comment" patch. No try, it's just a comment.
Keywords: checkin-needed,
leave-open
|
||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
|
|
Assignee | |
Updated•10 years ago
|
Keywords: leave-open
|
||
Comment 7•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•