1132529 - Symbolicate all C++ symbols when platform data is enabled

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Right now, you get a bunch of raw addresses. We should symbolicate all those. I don't know where we get the symbols from, though.

(Don't think this needs to block bug 1075567, but it would sure be awesome to have)

Comment 1

[Markus Stange [:mstange]]

(In reply to Nick Fitzgerald [:fitzgen] from comment #0)
> I don't know where we get the symbols from, though.

It's tricky. For official builds (e.g. Nightlies) and Windows system libraries, we can get the symbols from the mozilla symbol server (symbolapi.mozilla.org, code is at https://github.com/vdjeric/Snappy-Symbolication-Server/ ). For try server builds, the symbols are in the directory that the try build came from. For locally-compiled builds and system libraries on Mac and Linux, the Gecko profiler addon uses the command line utilities atos on Mac and addr2line on Linux for symbolication. For locally-compiled builds on Windows, you currently have to do a "mach buildsymbols" build step and launch a local symbol server. For Android and B2G system libraries, the addon copies the libraries to the host machine and use the Android ARM versions of the command line tools addr2line and nm from the Android SDK.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Markus Stange [:mstange] from comment #1)
> (In reply to Nick Fitzgerald [:fitzgen] from comment #0)
> > I don't know where we get the symbols from, though.
> 
> It's tricky. For official builds (e.g. Nightlies) and Windows system
> libraries, we can get the symbols from the mozilla symbol server
> (symbolapi.mozilla.org, code is at
> https://github.com/vdjeric/Snappy-Symbolication-Server/ ). For try server
> builds, the symbols are in the directory that the try build came from. For
> locally-compiled builds and system libraries on Mac and Linux, the Gecko
> profiler addon uses the command line utilities atos on Mac and addr2line on
> Linux for symbolication. For locally-compiled builds on Windows, you
> currently have to do a "mach buildsymbols" build step and launch a local
> symbol server. For Android and B2G system libraries, the addon copies the
> libraries to the host machine and use the Android ARM versions of the
> command line tools addr2line and nm from the Android SDK.

And presumably the gecko profiler addon has already written this code and we can move it into toolkit and share it? At least for official builds?

/me crosses fingers

Comment 3

[Benoit Girard (:BenWa)]

No, the code is a giant security nightmare since it just forks a new system shell, hope the right binary are there and calls them.

Comment 4

[Markus Stange [:mstange]]

Yeah, the addon code isn't something I'd be comfortable with just dropping into Firefox.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Dang. Well perhaps we can compromise and only symbolicate for official builds using the symbol server.

Comment 6

[Markus Stange [:mstange]]

I like that idea.

Comment 8

[Markus Stange [:mstange]]

Bug 968510 is something completely different. Unduping.
Bug 968510 is about JS functions that have names that follow the C++ mangling rules. This bug is about real C++ function addresses and symbolicating those to C++ function names.

Comment 9

[Victor Porof [:vporof][:vp]]

Thanks!

Comment 10

[Victor Porof [:vporof][:vp]]

Not specifically blocking v2.

Comment 11

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Nick Fitzgerald [:fitzgen] from comment #5)
> Dang. Well perhaps we can compromise and only symbolicate for official
> builds using the symbol server.

Perhaps we could have a pref for local builds to spawn a shell to use atos?

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

Please consider also handling symbolication of remote fennec/b2g devices. It is very painful right now with the profiler addon.

Comment 13

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #12)
> Please consider also handling symbolication of remote fennec/b2g devices. It
> is very painful right now with the profiler addon.

This would happen at the server level, so it would also happen for fennec and b2g. However, it may take longer for b2g to upgrade to a recent enough gecko, but that is a different issue.

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] from comment #13)
> (In reply to James Willcox (:snorp) ([e-mail]) from comment #12)
> > Please consider also handling symbolication of remote fennec/b2g devices. It
> > is very painful right now with the profiler addon.
> 
> This would happen at the server level, so it would also happen for fennec
> and b2g. However, it may take longer for b2g to upgrade to a recent enough
> gecko, but that is a different issue.

We would need to have some other stuff to do local builds. The Gecko Profiler add-on does this by locating the objdir and getting symbols from there.

Comment 15

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 16

[Greg Tatum [:gregtatum]]

Let's avoid symbolication for now in the DevTools workflow. The Gecko Profiler Add-on supports this and dumps out to the same perf.html interface.