1132531 - Add GPU profiling

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The gecko addon has it, so presumably we have the data and just need to render it. Gogogogo!

Comment 1

[Victor Porof [:vporof][:vp]]

Not specifically blocking v2.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

We can easily get this by adding the "gpu" feature to the profiler, and we'll get markers after the profile ends. Caveats:

* They won't be realtime, unlike all of our other markers -- might be weird.
* Once we start modifying profiler features, we'll have to figure out how to handle this, as we could have multiple recordings at once, and this would require stopping the profiler (can display a "warning" message indicating this or something)

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Chrome has something similar behind an experimental pref (hit shift 6 times), "GPU Data on Timeline". May or may not make it to release in this form.

http://i.imgur.com/TThF4KK.png

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Is the gecko profiler GPU data useful for your use cases, Daosheng?

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Same for you Vlad -- is the gecko profiler GPU data useful for web VR debugging currently?

Comment 6

[Daosheng Mu[:daoshengmu]]

Jordan, I will confirm it this week. Sorry for I am a little busy in this couple of days.

Comment 7

[Daosheng Mu[:daoshengmu]]

Attachment: Get profile data from gecko profiler

var selectedFeatures = [];
  selectedFeatures.push("leaf");
  selectedFeatures.push("gpu");
  var entries = 1000000;
  var interval = 1;
  var threadFilter = 'GeckoMain,Compositor';

profile.start(entries, interval, selectedFeatures, threadFilter.split(','));

Comment 8

[Daosheng Mu[:daoshengmu]]

Jordan, I have checked the GPU marker of Chrome, and it seems to be no longer supported. Gecko profiler is pretty great. I think it can give me lots of information for gaming profiling tool. Like refresh frame time, GPU time, and Composite time.

But, after trying it as attachment 8654513 [details], I find I can't get GPU time from this profile data even though I selected "gpu" feature. Benoit, could you tell how to parse the profile data to get refresh frame time, GPU time, and Composite time. Like you did in Cleopatra.

Thanks.

Comment 9

[Benoit Girard (:BenWa)]

Its only implemented on Mac. Did you try there? So far the data has not been very useful for platform. I'm not convinced timer queries are sufficiently useful. But it might be better for webgl.

Comment 10

[Daosheng Mu[:daoshengmu]]

Benoit, I ran it on my Mac, and it uses add-on to Cleopatra. It can show the GPU markers. But, if I use gecko profiler API inside devTool, I can't any data that is related to GPU. Therefore, I think I might exploit wrong features to get GPU time.

Besides, I have tried Gecko profiler add-on on Windows and Ubuntu. It can not catch the GPU time. My original purpose of game profiling tool is to be executed for developers on any platform, especially for Windows, because most of game developers come from Windows.

Comment 11

[Daosheng Mu[:daoshengmu]]

Benoit, I use the some usage of Gecko profiler API inside devTool and make it start profiling while I initialize the devTool. I can get the GPU time data right now. I think GPU time probably has to wait for a while until it's ready. Thanks a lot.

Comment 12

[Benoit Girard (:BenWa)]

It wont work on Windows/Linux ATM because it's not implemented there.

I don't force a flush of the results, they are just posted some time after they are ready.

The current feature is not suitable to build on top of. We need to spend more time experimenting with the GPU perf APIs and finding the most suitable thing to expose. Also what we use to monitor layers composite time isn't what we will want to expose to game developers doing canvas/webgl performance work.

Comment 13

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 14

[Greg Tatum [:gregtatum]]

We capture markers and render them liberally in perf.html. This is no longer relevant, but we should file follow-up bugs if we want specific GPU enhancements.