1132551 - [RTL][Contacts] Icons are Left Aligned in Import/Export Contacts menus.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Martin Shuman [:Marty]]

Attachment: RTL Contacts Left Align.png

Description:
If the user selects  Import or Export Contacts in the Contacts Settings menu, they will see that the icons for SIM, Memory Card, Gmail, Outlook, and Bluetooth are improperly left aligned

Repro Steps:
1) Update a Flame to 20150212010213
2) Open the Contacts app
3) Tap the 'Gear' icon to open the Settings menu.
4) Select 'Import Contacts'

Actual:
Icons are left aligned.

Expected:
Icons are Right Aligned.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150212010213
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 3094601af679
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 5/5
See attached: screenshot

------------------------------------------

This issue DOES occur on Flame 2.2.
Icons are left aligned.

Environmental Variables:
Device: Flame 2.2
Build ID: 20150212002504
Gaia: 791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko: 5dec207fcbeb
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Dylan Oliver [:doliver]]

triage: P2. inconsistent with spec & Settings app but does not cause confusion or impede functionality.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] anefzaoui:bug-1132551 > mozilla-b2g:master

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8565379 [details] [review]
[gaia] anefzaoui:bug-1132551 > mozilla-b2g:master

Looking great thanks!

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Thanks!

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/dc92f3fc3465bbbd3596790bc2afa4e120f4cfbd

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8565379 [details] [review]
[gaia] anefzaoui:bug-1132551 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Lack of RTL implementation
[User impact] if declined: icons misplaced: attachment 8563519 [details]
[Testing completed]: yes, flame
[Risk to taking this patch] (and alternatives if risky): RTL-specific css addition, very low risk
[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/bee6813ec27d76ba4260ead1263597641b28bf39

Comment 8

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is fixed in the latest Nightly 3.0 Flame build.  

Results:  The icons are on the right.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150219010228
Gaia: 620aecfde85a8b093247837c55de2708e22be1e1
Gecko: 360b5f211180
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


In the latest Nightly 2.2 Flame build the icons are on the right but overlap with the text, likely as a results of bug 1130231 being uplifted to 2.2.

Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150219002504
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: 159a3907b959
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

There is a bug for the overlap already written as bug 1132672.