1132555 - Make sure WorkerFeature::Suspend() and ::Resume() are called properly

Status: RESOLVED DUPLICATE of bug 1235629

(Core :: DOM: Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently WorkerFeature defines virtual methods Suspend() and Resume(). These methods are never called and therefore have no defined behavior.

We should just remove these for now to avoid confusing people.  If workers actually grows the capability to call them, then they can be added back.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I'd actually rather we fix this so that we do call Suspend/Resume on them... I'd love to pause network loads and maybe other big IPC stuff.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Removing them for now and restoring them later is trivial.  Implementing what you are talking about is probably non-trivial.  (I assume since its not already done.)

Seems a little weird to me to leave cruft in the tree while waiting for someone to implement a non-trivial feature.  Until its implemented these methods are meaningless and just serve to confuse people.

Just my opinion.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

My original suggestion was implemented over in bug 1235629.