1132720 - Hide ShareDialog at the end of the exit animation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Otherwise it may pop in while the activity is finishing and it's ugly.

Patch builds on bug 1122302.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1132720/mcomella

/r/4105 - Bug 1132720 - Hide the dialog on animation end to prevent flicker on Activity.finish(). r=margaret

Pull down this commit:

hg pull review -r ea91db60b92fa061fd2493849702388c4e6aa01b

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I took it off of bug 1122302

Comment 3

[:Margaret Leibovic]

Comment on attachment 8567218 [details]
MozReview Request: bz://1132720/mcomella

https://reviewboard.mozilla.org/r/4103/#review3271

Ship It!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/64b25e313439

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64b25e313439

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Probably should have uplifted to 36. :(

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8567218 [details]
MozReview Request: bz://1132720/mcomella

Approval Request Comment
[Feature/regressing bug #]: Share overlay
[User impact if declined]:
  Users see a flicker when the share overlay is closed

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  We hide the dialog on animation end - I don't really see where this can go wrong.

[String/UUID change made/needed]: None

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8567218 [details]
MozReview Request: bz://1132720/mcomella

Looks like a trivial fix and we're still early in Beta. Beta+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9fb3cc1f7ff6

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Alcatel One Touch (Android 4.1.2)

On Firefox 36.0.1 a flicker appears when the "Bookmark" option is chosen and the share overlay is closed.
Not able to reproduce it on Firefox 37 Beta 4.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

No flicker is displayed when the "Bookmark" option is chosen and the share overlay is closed, so:
Verified fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 38.0a2 (2015-03-19)

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1132720 - Hide the dialog on animation end to prevent flicker on Activity.finish(). r=margaret