Closed Bug 1132720 Opened 5 years ago Closed 5 years ago

Hide ShareDialog at the end of the exit animation

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 38
Tracking Status
firefox36 --- wontfix
firefox37 --- verified
firefox38 --- verified

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Otherwise it may pop in while the activity is finishing and it's ugly.

Patch builds on bug 1122302.
No longer depends on: 1122302
/r/4105 - Bug 1132720 - Hide the dialog on animation end to prevent flicker on Activity.finish(). r=margaret

Pull down this commit:

hg pull review -r ea91db60b92fa061fd2493849702388c4e6aa01b
Attachment #8567218 - Flags: review?(margaret.leibovic)
I took it off of bug 1122302
No longer depends on: 1122302
Comment on attachment 8567218 [details]
MozReview Request: bz://1132720/mcomella

https://reviewboard.mozilla.org/r/4103/#review3271

Ship It!
Attachment #8567218 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/64b25e313439
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Probably should have uplifted to 36. :(
Comment on attachment 8567218 [details]
MozReview Request: bz://1132720/mcomella

Approval Request Comment
[Feature/regressing bug #]: Share overlay
[User impact if declined]:
  Users see a flicker when the share overlay is closed

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  We hide the dialog on animation end - I don't really see where this can go wrong.

[String/UUID change made/needed]: None
Attachment #8567218 - Flags: approval-mozilla-beta?
Comment on attachment 8567218 [details]
MozReview Request: bz://1132720/mcomella

Looks like a trivial fix and we're still early in Beta. Beta+
Attachment #8567218 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Tested with:
Device: Alcatel One Touch (Android 4.1.2)

On Firefox 36.0.1 a flicker appears when the "Bookmark" option is chosen and the share overlay is closed.
Not able to reproduce it on Firefox 37 Beta 4.
No flicker is displayed when the "Bookmark" option is chosen and the share overlay is closed, so:
Verified fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 38.0a2 (2015-03-19)
Status: RESOLVED → VERIFIED
Attachment #8567218 - Attachment is obsolete: true
Attachment #8619469 - Flags: review+
You need to log in before you can comment on or make changes to this bug.