1132967 - [Windows Management] [Notifications] Notifications are unable to or difficult to scroll on the notification menu.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150213_0904.txt

Description:
When notifications exceed the size of the notification menu the user is able to scroll to see them. Currently the notifications are difficult to scroll. It is often unresponsive but will occasionally work. When it does work you can scroll up and down until you lift your finger, and then it 'resets' and may not scroll again.

Repro Steps:
1) Update a Flame to 20150213010213
2) Fill up your notification menu (screenshots work great for this)
3) Pull down the notification bar to access the notification menu
4) Attempt to scroll the notifications

Actual:
Notification menu difficult to scroll / sometimes unresponsive

Expected:
Menu will always be responsive and scrollable

Environmental Variables:
Device: Flame 3.0
Build ID: 20150213010213
Gaia: 2a2b008f9ae957fe19ad540d233d86b5c0b6829e
Gecko: 2f5c5ec1a24b
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 7/9
See attached: logcat
------------------------------------------------------------------

This issues does NOT repro in 2.2

Device: Flame 2.2 (KK - Nightly - Full Flash)
Build ID: 20150213002503
Gaia: ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gecko: d04b78eeb536
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Performance regression of a core feature.

Requesting a window.

Comment 2

[Yeojin Chung [:YeojinC]]

Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150211190942
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 6ed69c4d2c15
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150211230942
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 07479758ab68
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 07479758ab68

First Broken Gaia Last Working Gecko: Issue does NOT reproduce
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 6ed69c4d2c15

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6ed69c4d2c15&tochange=07479758ab68

caused by bug 1127066

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Botond, here is another issue that is pointing to the same bug 1127066

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This is a Gaia bug; the code at [1] is causing the pan attempts to get killed. This was exposed by bug 1127066 because before that we weren't properly respecting preventDefault() on the first touchmove event, but now we are.

Chris, as you seem to have been the last one to touch the code in question, mind taking a look at this?

[1] https://github.com/mozilla-b2g/gaia/blob/404bbb2cefb34241e0e4aa1b1fea2ddd51c0d7bc/apps/system/js/notifications.js#L265

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Note that this will affect 2.2 as well since bug 1127066 has been uplifted there (very recently, which is probably it didn't show up in the branch checks).

Comment 6

[Chris Lord [:cwiiis]]

Taking.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1132967-scroll-notifications > mozilla-b2g:master

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8566039 [details] [review]
[gaia] Cwiiis:bug1132967-scroll-notifications > mozilla-b2g:master

Works like a charm!

Comment 9

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 10

[Chris Lord [:cwiiis]]

Merged manually: https://github.com/mozilla-b2g/gaia/commit/9b19f34c88239160001b87472f5966e9885889a4

Comment 11

[Chris Lord [:cwiiis]]

Comment on attachment 8566039 [details] [review]
[gaia] Cwiiis:bug1132967-scroll-notifications > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Can't scroll utility tray when there are many notifications
[Testing completed]: Tested manually
[Risk to taking this patch] (and alternatives if risky): No risk, minimal change
[String changes made]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2b694a5a332495f1b9db06253690a2f5a702ed80

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.  
	
Actual Results: Notifications are easily scrolled through.

Environmental Variables:
Device: Flame 3.0 KK (319MB)(Full Flash)
BuildID: 20150225010244
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319MB)(Full Flash)
BuildID: 20150225002505
Gaia: ca64f2fe145909f31af266b1730874051ba76c78
Gecko: 16804008c29f
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0