1133228 - Address book search box should have flexible width

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Philip Chee]

SeaMonkey version of Thunderbird Bug 669235

(From Bug 669235 comment #0)
> Add flex="1" to the toolbaritem containing the search box
> 
> The address book search box is statically sized. I think it should be
> flexible, like the gloda search box, since it's currently a waste of space
> if you size the address book to be fairly wide.

Comment 1

[Philip Chee]

Attachment: Add flex to the searchBox

Comment 2

[Philip Chee]

Attachment: Patch v1 Add flex to the searchBox

Comment 3

[Ian Neal]

For when customising, does it also need something like:
http://mxr.mozilla.org/comm-central/source/suite/themes/classic/mac/messenger/primaryToolbar.css#217
http://mxr.mozilla.org/comm-central/source/suite/themes/classic/messenger/primaryToolbar.css#255
http://mxr.mozilla.org/comm-central/source/suite/themes/modern/messenger/primaryToolbar.css#292

I am also not sure about setting the max-width, the searchToolbar for the main mail window doesn't seem to need it.

Comment 4

[Philip Chee]

(In reply to Ian Neal from comment #3)
> For when customising, does it also need something like:
> http://mxr.mozilla.org/comm-central/source/suite/themes/classic/mac/messenger/primaryToolbar.css#217
> http://mxr.mozilla.org/comm-central/source/suite/themes/classic/messenger/primaryToolbar.css#255
> http://mxr.mozilla.org/comm-central/source/suite/themes/modern/messenger/primaryToolbar.css#292

toolbarpaletteitems are already constrained to 110px. With a 10px font, 110px corresponds to 11em.
Here's a handy web converter for you http://pxtoem.com/ .

> I am also not sure about setting the max-width, the searchToolbar for the
> main mail window doesn't seem to need it.

The searchToolbar in the main mail window is on a toolbar with several other wide toolbar items. In the addressbook all the items on the primary toolbar are buttons except for the searchbox.

Comment 5

[Ian Neal]

Comment on attachment 8564579 [details] [diff] [review]
Patch v1 Add flex to the searchBox

Having tested without the max-width, it seems to work better (maybe it is just on linux). r=me without the css changes unless there is an issue on other platforms.

Comment 6

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/ff495d26d67c