669235 - Address book search box should have flexible width

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Jim Porter (:squib)]

Attachment: Add flex="1" to the toolbaritem containing the search box

The address book search box is statically sized. I think it should be flexible, like the gloda search box, since it's currently a waste of space if you size the address book to be fairly wide. Attached is a (very) simple patch to do this.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 543843 [details] [diff] [review]
Add flex="1" to the toolbaritem containing the search box

If this is "take up the rest of the toolbar" by default, then I think I disagree. If its stretch in proportion, then that's probably fine.

In any case, this sort of change should have ui-review first.

Comment 2

[Jim Porter (:squib)]

Attachment: Before and after

To simplify ui review, here's a before and after shot using (I believe) the default size for the address book.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 543843 [details] [diff] [review]
Add flex="1" to the toolbaritem containing the search box

I've played around with this for a while, and it seems quite a bit better.  ui-r=me!

Thanks,
Blake.

Comment 4

[Jim Porter (:squib)]

Comment on attachment 543843 [details] [diff] [review]
Add flex="1" to the toolbaritem containing the search box

Requesting review again now that I have ui-r+.

Comment 5

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/b1de7404347d