1133237 - [e10s] Hulu sometimes stays on screen after tab switch

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Not sure if this been filed yet...

If I start a Flash video on Hulu in Linux and then switch to another tab, the video sometimes is still displayed. It only happens maybe 25% of the time. I can't figure out an easy way to reproduce it unfortunately.

Comment 1

[Jim Mathies [:jimm]]

+ing for now, will come back to this once I get get the parent fixed.

Comment 2

[Jim Mathies [:jimm]]

I reproduced this on Windows today too.

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

Comment 4

[Jim Mathies [:jimm]]

Attachment: patch

This fixes a case where switching from a tab with plugins to a tab without any plugins might leave the previous tab's plugins visible.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8571577 [details] [diff] [review]
patch

Review of attachment 8571577 [details] [diff] [review]:
-----------------------------------------------------------------

We need some tests for this sort of thing.

You should be able to write one using the test plugin.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5)
> Comment on attachment 8571577 [details] [diff] [review]
> patch
> 
> Review of attachment 8571577 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> We need some tests for this sort of thing.
> 
> You should be able to write one using the test plugin.

Thanks, will do.

Comment 7

[Jim Mathies [:jimm]]

Attachment: patch for checkin r=roc

Comment 8

[Jim Mathies [:jimm]]

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1523bf6a1ed

Comment 9

[Jim Mathies [:jimm]]

Attachment: patch for checkin r=roc

fix: UpdatePluginWindowState shouldn't get called on macos.

Unfortunately try is currently closed, waiting on that to reopen to push again.

Comment 10

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=592e3457ffaf

Comment 11

[Jim Mathies [:jimm]]

Attachment: patch for checkin r=roc

Same patch, only with UpdatePluginWindowState wrapped in ifdefing to avoid a warning on mac.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b18ac4cbbeaa

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb6f6c017ce

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3eb6f6c017ce