Closed
Bug 1133387
Opened 10 years ago
Closed 10 years ago
jwplayer - The UI progress bar overlaps menu buttons
Categories
(Firefox Graveyard :: Shumway, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yury, Assigned: tschneider)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
|
3.51 KB,
patch
|
Details | Diff | Splinter Review |
The UI progress bar overlaps everything in the pop up menu.
The first bad revision is:
changeset: 228180:9ddd307bb5d1
user: Tooru Fujisawa <arai_a@mac.com>
date: Tue Feb 10 02:04:30 2015 +0900
summary: Bug 1120169 - Implement RegExp.prototype.{global, ignoreCase, multiline, source, sticky, unicode}. r=till
| Reporter | ||
Updated•10 years ago
|
Summary: jwplayer UI regressed → jwplayer - The UI progress bar overlaps menu buttons
Comment 1•10 years ago
|
||
Seems to be a trouble related to RegExp.prototype.source.
Applying this patch fixes the issue.
Comment 2•10 years ago
|
||
in shumway.player.js:15404
http://areweflashyet.com/shumway/build/bundles/shumway.player.js
> regex = augment(new RegExp(regex.source, flags), hasNamedCapture(regex) ? regex[REGEX_DATA].captureNames.slice(0) : null, options.addProto);
`regex.source` returns `undefined` (other flags are also `undefined`), because the there is no source getter in prototype chain.
Comment 3•10 years ago
|
||
https://github.com/mozilla/shumway/pull/2081
Also, there should be related behavior differences in `source`, caused by bug 1130860 and bug 1130798.
new RegExp("", "").source
new RegExp("\r\n", "").source
new RegExp("\u2028\u2029").source
Updated•10 years ago
|
Assignee: nobody → schneider
Depends on: shumway-jw1
| Assignee | ||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•