Closed Bug 1133805 Opened 5 years ago Closed 5 years ago

Fix and re-enable test_unregister.html, test_workerUpdate.html and test_workerUnregister.html

Categories

(Core :: DOM: Core & HTML, defect)

33 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: nsm, Assigned: nsm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → nsm.nikhil
Summary: Fix and re-enable test_unregister.html and test_workerUnregister.html → Fix and re-enable test_unregister.html, test_workerUpdate.html and test_workerUnregister.html
test_workerUpdate was hitting intermittent asserts too in addition to the timeouts.
https://treeherder.mozilla.org/logviewer.html#?job_id=6697595&repo=mozilla-inbound
See Also: → 1134067
It is quite possible that the fix is a simple undefined error. I'm awaiting several try runs that may fix both these intermittents.
Attached patch Fix SW intermittents (obsolete) — Splinter Review
Based on my try runs this 'a is undefined' error due to non-existent registration seems to be causing all the intermittents. I'm not sure why a JS error was doing that, but the results seem to speak for themselves

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e061f64f46a
Attachment #8566425 - Flags: review?(amarchesini)
Comment on attachment 8566425 [details] [diff] [review]
Fix SW intermittents

Review of attachment 8566425 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/simpleregister/index.html
@@ -36,5 @@
>              }
>            });
>  
> -          navigator.serviceWorker.getRegistration('http://mochi.test:8888/with_star/*')
> -            .then(function(a) {

but in theory this should work, correct? So we have some kind of bug somewhere... right?
Attachment #8566425 - Flags: review?(amarchesini)
There is no longer any registration call for with_star scope. Which means 'a' is undefined.
Ugh, actually ignore this. I just realized the try push had the tests disabled :(
Attachment #8566425 - Flags: review+
Comment on attachment 8572798 [details] [diff] [review]
Enable worker update and unregister tests

Review of attachment 8572798 [details] [diff] [review]:
-----------------------------------------------------------------

if green on try!
Attachment #8572798 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/85a9d5f966ac
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.